From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Zang Roy-r61911 <tie-fei.zang@freescale.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
Alexandre.Bounine@tundra.com,
Yang Xin-Xin-r48390 <Xin-Xin.Yang@freescale.com>
Subject: Re: [PATCH] powerpc: update mpc7448hpc2 board irq support usingdevice tree
Date: Thu, 24 Aug 2006 15:50:59 +1000 [thread overview]
Message-ID: <1156398659.8433.193.camel@localhost.localdomain> (raw)
In-Reply-To: <1156397344.5913.34.camel@localhost.localdomain>
> -struct hw_interrupt_type tsi108_pci_irq = {
> +static struct irq_chip tsi108_pci_irq = {
> .typename = "tsi108_PCI_int",
> - .enable = tsi108_pci_irq_enable,
> - .disable = tsi108_pci_irq_disable,
> + .mask = tsi108_pci_irq_disable,
> .ack = tsi108_pci_irq_ack,
> .end = tsi108_pci_irq_end,
> + .unmask = tsi108_pci_irq_enable,
> };
>
> /*
While the patch as-is looks ok, it also looks like you could take
advantage of the new genirq code to clean up your TSI irq handling a
bit. You probably don't need a end() handler anymore provided that you
properly set your main handler to be either level, edge or fasteoi (in
which case, you need an eoi handler).
Ben.
next prev parent reply other threads:[~2006-08-24 5:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 2:19 [PATCH] powerpc: update mpc7448hpc2 board irq support using device tree Zang Roy-r61911
2006-08-23 3:38 ` Benjamin Herrenschmidt
2006-08-23 11:45 ` [PATCH] powerpc: update mpc7448hpc2 board irq support usingdevice tree Zang Roy-r61911
2006-08-24 5:29 ` Zang Roy-r61911
2006-08-24 5:50 ` Benjamin Herrenschmidt [this message]
2006-08-24 8:36 ` [PATCH] powerpc: update mpc7448hpc2 board irq supportusingdevice tree Zang Roy-r61911
2006-08-24 8:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156398659.8433.193.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Alexandre.Bounine@tundra.com \
--cc=Xin-Xin.Yang@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).