From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 593C467C38 for ; Thu, 24 Aug 2006 15:51:10 +1000 (EST) Subject: Re: [PATCH] powerpc: update mpc7448hpc2 board irq support usingdevice tree From: Benjamin Herrenschmidt To: Zang Roy-r61911 In-Reply-To: <1156397344.5913.34.camel@localhost.localdomain> References: <7EA18FDD2DC2154AA3BD6D2F22A62A0E26E531@zch01exm23.fsl.freescale.net> <1156304338.8433.21.camel@localhost.localdomain> <1156397344.5913.34.camel@localhost.localdomain> Content-Type: text/plain Date: Thu, 24 Aug 2006 15:50:59 +1000 Message-Id: <1156398659.8433.193.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev list , Paul Mackerras , Alexandre.Bounine@tundra.com, Yang Xin-Xin-r48390 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -struct hw_interrupt_type tsi108_pci_irq = { > +static struct irq_chip tsi108_pci_irq = { > .typename = "tsi108_PCI_int", > - .enable = tsi108_pci_irq_enable, > - .disable = tsi108_pci_irq_disable, > + .mask = tsi108_pci_irq_disable, > .ack = tsi108_pci_irq_ack, > .end = tsi108_pci_irq_end, > + .unmask = tsi108_pci_irq_enable, > }; > > /* While the patch as-is looks ok, it also looks like you could take advantage of the new genirq code to clean up your TSI irq handling a bit. You probably don't need a end() handler anymore provided that you properly set your main handler to be either level, edge or fasteoi (in which case, you need an eoi handler). Ben.