From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Li Yang-r58472 <LeoLi@freescale.com>
Cc: linuxppc-dev@ozlabs.org,
Phillips Kim-R1AAHA <Kim.Phillips@freescale.com>
Subject: RE: [PATCH 1/3] Adapt ipic driver to new host_ops interface, addset_irq_type to set IRQ sense
Date: Thu, 24 Aug 2006 15:56:22 +1000 [thread overview]
Message-ID: <1156398982.8433.200.camel@localhost.localdomain> (raw)
In-Reply-To: <4879B0C6C249214CBE7AB04453F84E4D0FC2F3@zch01exm20.fsl.freescale.net>
> But for IRQ with a specified type, set_irq_type() will be called two
> times continuously. Why not call the set_irq_type() in any case in
> irq_create_of_mapping()?
well... it would still not be called by irq_create_mapping() (the non-OF
one). You need to make sure your stuff is properly initialized in the
case there it's not called. That is that you have a proper default irq
type, handler, and HW setup after host_map() returns.
It's not terribly harmful to have set_irq_type() called twice. Another
option is to have host_map re-do what your set_type() does, or move the
common code into a low level __set_type() that gets called by both
set_irq_type() and your host_map ...
Ben.
next prev parent reply other threads:[~2006-08-24 5:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 1:39 [PATCH 1/3] Adapt ipic driver to new host_ops interface, add set_irq_type to set IRQ sense Kim Phillips
2006-08-24 1:58 ` Kumar Gala
2006-08-24 3:45 ` Benjamin Herrenschmidt
2006-08-24 3:44 ` Benjamin Herrenschmidt
2006-08-24 5:44 ` [PATCH 1/3] Adapt ipic driver to new host_ops interface, addset_irq_type " Li Yang-r58472
2006-08-24 5:56 ` Benjamin Herrenschmidt [this message]
2006-08-24 7:39 ` Li Yang-r58472
2006-08-24 7:58 ` [PATCH 1/3] Adapt ipic driver to new host_ops interface,addset_irq_type " Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156398982.8433.200.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=Kim.Phillips@freescale.com \
--cc=LeoLi@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).