Re: [PATCH] powerpc: update mpc7448hpc2 board irq supportusingdevice tree

[Zang Roy-r61911 <tie-fei.zang@freescale.com>]

On Thu, 2006-08-24 at 13:50, Benjamin Herrenschmidt wrote:
> > -struct hw_interrupt_type tsi108_pci_irq = {
> > +static struct irq_chip tsi108_pci_irq = {
> >       .typename = "tsi108_PCI_int",
> > -     .enable = tsi108_pci_irq_enable,
> > -     .disable = tsi108_pci_irq_disable,
> > +     .mask = tsi108_pci_irq_disable,
> >       .ack = tsi108_pci_irq_ack,
> >       .end = tsi108_pci_irq_end,
> > +     .unmask = tsi108_pci_irq_enable,
> >  };
> >  
> >  /*
> 
> While the patch as-is looks ok, it also looks like you could take
> advantage of the new genirq code to clean up your TSI irq handling a
> bit. You probably don't need a end() handler anymore provided that you
> properly set your main handler to be either level, edge or fasteoi (in
> which case, you need an eoi handler).
I need the end() handler. The main handler can not proper process the
case.
Roy