From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: powerpc virq: minor cleanups
Date: Mon, 28 Aug 2006 11:20:38 +1000 [thread overview]
Message-ID: <1156728038.8433.410.camel@localhost.localdomain> (raw)
In-Reply-To: <44EF8182.2000401@am.sony.com>
On Fri, 2006-08-25 at 16:02 -0700, Geoff Levand wrote:
> Ben,
>
> Please consider these cleanups.
>
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> Index: cell--common--4/arch/powerpc/kernel/irq.c
> ===================================================================
> --- cell--common--4.orig/arch/powerpc/kernel/irq.c
> +++ cell--common--4/arch/powerpc/kernel/irq.c
> @@ -678,7 +680,7 @@
> }
> EXPORT_SYMBOL_GPL(irq_dispose_mapping);
>
> -unsigned int irq_find_mapping(struct irq_host *host,
> +unsigned int irq_find_mapping(const struct irq_host *host,
> irq_hw_number_t hwirq)
> {
> unsigned int i;
> Index: cell--common--4/include/asm-powerpc/irq.h
> ===================================================================
> --- cell--common--4.orig/include/asm-powerpc/irq.h
> +++ cell--common--4/include/asm-powerpc/irq.h
> @@ -28,10 +28,10 @@
>
> #ifdef CONFIG_PPC_MERGE
>
> -/* This number is used when no interrupt has been assigned */
> +/* This number is used when no virq has been assigned */
> #define NO_IRQ (0)
>
> -/* This is a special irq number to return from get_irq() to tell that
> +/* This is a special virq number to return from get_irq() to tell that
> * no interrupt happened _and_ ignore it (don't count it as bad). Some
> * platforms like iSeries rely on that.
> */
> @@ -217,7 +222,7 @@
> * irq controller implementation directly calls the appropriate low level
> * mapping function.
> */
> -extern unsigned int irq_find_mapping(struct irq_host *host,
> +extern unsigned int irq_find_mapping(const struct irq_host *host,
> irq_hw_number_t hwirq);
>
>
prev parent reply other threads:[~2006-08-28 1:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 23:02 powerpc virq: minor cleanups Geoff Levand
2006-08-28 1:20 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156728038.8433.410.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).