From: Josh Boyer <jwboyer@jdub.homelinux.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, mporter@embeddedalley.com
Subject: Re: [PATCH] PPC 4xx: Enable XMON on PPC 4xx boards
Date: Wed, 06 Sep 2006 18:50:47 -0500 [thread overview]
Message-ID: <1157586647.2721.27.camel@vader.jdub.homelinux.org> (raw)
In-Reply-To: <17663.20973.922238.823386@cargo.ozlabs.ibm.com>
On Thu, 2006-09-07 at 08:55 +1000, Paul Mackerras wrote:
> Josh Boyer writes:
>
> > - excp->msr |= 0x400;
> > + excp->msr |= MSR_SSTEP_ENABLE;
> > +#ifdef CONFIG_4xx
> > + mtspr(SPRN_DBCR0, mfspr(SPRN_DBCR0) | DBCR0_IC | DBCR0_IDM);
> > +#endif
> > } else if (at_breakpoint(excp->nip)) {
> > xmon_trace[smp_processor_id()] = BRSTEP;
> > - excp->msr |= 0x400;
> > + excp->msr |= MSR_SSTEP_ENABLE;
> > +#ifdef CONFIG_4xx
> > + mtspr(SPRN_DBCR0, mfspr(SPRN_DBCR0) | DBCR0_IC | DBCR0_IDM);
> > +#endif
>
> This would be neater with a little inline xmon_enable_sstep(excp)
> function...
>
> Other than that, looks fine.
Agreed. I'll make that change and resend in the morning.
josh
prev parent reply other threads:[~2006-09-06 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 18:58 [PATCH] PPC 4xx: Enable XMON on PPC 4xx boards Josh Boyer
2006-09-06 22:55 ` Paul Mackerras
2006-09-06 23:50 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157586647.2721.27.camel@vader.jdub.homelinux.org \
--to=jwboyer@jdub.homelinux.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mporter@embeddedalley.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox