Re: [Fwd: Re: ohci1394: steps to implement suspend/resume]

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Wed, 2006-09-06 at 16:46 +0200, Stefan Richter wrote:
> Hello LinuxPPC-dev,
> 
> we have now patches coming in to fix up the lack of generic suspend +
> resume support in drivers/ieee1394/ohci1394. Attached is the latest and
> by far most functional one by Bernhard Kaindl. A big question is how
> this relates to the already existing PPC-PMAC platform code in
> ohci1394's suspend and resume hooks.
> 
>  - Which functionalities does the existing platform code provide in
>    detail?
> 
>  - Do we have to keep platform code and generic code separate? I.e.
> #ifdef CONFIG_PPC_PMAC
> 	...pmac_call_feature...
> #else
> 	...new generic code...
> #endif
> 
>  - Or are parts of the until now missing, new generic code necessary
>    for PMacs too? If yes, is the platform code treated to be the lowest
>    level as far as the oreder of code is concerned?
> 
>  - Or would the platform code be obsolete?
> 
> We already broke your platform code once by what was meant as a bugfix
> for non-PMacs. It'd be good to know enough to not repeat such mistakes...

The PowerMac code will stop the chip clocks. It should be used as the
last step of the suspend sequence and first step of the return sequence,
in _addition_ to your new code. Note also that the code you posted lacks
calls to pci_set_power_state()...

Ben.