linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollis@penguinppc.org>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: common flatdevtree code
Date: Thu, 07 Sep 2006 02:43:31 -0500	[thread overview]
Message-ID: <1157615011.18137.14.camel@diesel> (raw)
In-Reply-To: <20060907003625.GA15533@mag.az.mvista.com>

Thanks Mark!

On Wed, 2006-09-06 at 17:36 -0700, Mark A. Greer wrote:
> void *ft_find_device(const void *bphp, const char *srch_path)

How about "ft_find_node"? I renamed that and made a couple other small
changes. In particular:
- u8->int
- exit and free -> ft_exit and ft_free (so they can be wrapped in
flatdevtree_env.h)
- moved those inlines out of flatdevtree.h, since they don't need to be
exported

I just put up a Mercurial tree. I didn't include your flatdevtree_misc.c
since it's kernel-specific, and I added a userspace flatdevtree_env.h.

To get the source:
hg clone http://unsanctioned.org/flatdevtree/hgweb.py flatdevtree

I'd like to add some unit tests in the near future (e.g. comparing with
dtc output), but I wasted a couple hours screwing with a makefile
instead. :(

By the way, could you send a patch adding your copyright info?

-Hollis

  reply	other threads:[~2006-09-07  7:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-31 18:40 common flatdevtree code Mark A. Greer
2006-09-06  3:52 ` Paul Mackerras
2006-09-06 18:14   ` Mark A. Greer
2006-09-07  0:36   ` Mark A. Greer
2006-09-07  7:43     ` Hollis Blanchard [this message]
2006-09-07 18:27       ` Mark A. Greer
2006-09-07 22:23         ` Hollis Blanchard
2006-09-08  0:56           ` Mark A. Greer
2006-09-08  1:11             ` Mark A. Greer
2006-09-08 13:23             ` Paul Mackerras
2006-09-08 16:51               ` Mark A. Greer
2006-09-19 19:45               ` Mark A. Greer
2006-09-27 22:32                 ` Paul Mackerras
2006-09-27 22:55                   ` Hollis Blanchard
2006-09-27 23:41                   ` Segher Boessenkool
2006-09-27 23:52                     ` Hollis Blanchard
2006-09-28  0:51                       ` Segher Boessenkool
2006-09-28 19:34                       ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157615011.18137.14.camel@diesel \
    --to=hollis@penguinppc.org \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=mgreer@mvista.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).