From: Josh Boyer <jdub@us.ibm.com>
To: Matt Porter <mporter@embeddedalley.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] [v2] PPC 4xx: Enable XMON on PPC 4xx boards
Date: Thu, 07 Sep 2006 08:29:53 -0500 [thread overview]
Message-ID: <1157635794.6098.45.camel@zod.rchland.ibm.com> (raw)
In-Reply-To: <20060907132319.GA476@matthew-porters-computer.local>
On Thu, 2006-09-07 at 09:23 -0400, Matt Porter wrote:
>
> These can be represented with CONFIG_44x. Though it doesn't work for
> 440EP since it doesn't have the 36-bit memory map. It should be:
>
> +#elif ( defined(CONFIG_44x) && !defined(CONFIG_440EP) )
> + sccd = (volatile unsigned char *) ioremap64(0x0000000140000200ULL, 8);
> + sccc = sccd + 5;
> + TXRDY = 0x20;
> + RXRDY = 1;
> + DLAB = 0x80;
Right. I don't have access to a 440EP board anymore, so I couldn't test
it.
> Adding in another case would enable 440EP as well:
>
> +#elif ( defined(CONFIG_440EP) )
> + sccd = (volatile unsigned char *) ioremap(0xef600300, 8);
> + sccc = sccd + 5;
> + TXRDY = 0x20;
> + RXRDY = 1;
> + DLAB = 0x80;
That seems correct to me. I'll add that and send out another version
shortly.
josh
prev parent reply other threads:[~2006-09-07 13:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 12:33 [PATCH] [v2] PPC 4xx: Enable XMON on PPC 4xx boards Josh Boyer
2006-09-07 13:23 ` Matt Porter
2006-09-07 13:29 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157635794.6098.45.camel@zod.rchland.ibm.com \
--to=jdub@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mporter@embeddedalley.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).