Re: [PATCH] powerpc: Quiet hvc_console console output on failed opens

[Ryan Arnold <rsa@us.ibm.com>]

On Thu, 2006-09-07 at 15:18 -0500, Olof Johansson wrote:
> Hi,
> 
> Please consider for the 2.6.19 queue:
> 
> 
> 
> No other tty driver will print on the console when the open of it fails.
> 
> On systems that happen to be configured for both ttyS0 and hvc0 console,
> this will keep flooding the console output.  This is most likely to
> happen with systems booted between with and without hypervisor from the
> same filesystem.
> 
> Let's just remove it. When it's really needed (i.e. when the open fails
> and someone is trying to debug it), noone will see the output anyway. And
> init will report the opens failing in due time through the syslog.
> 
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>
> 
> Index: merge/drivers/char/hvc_console.c
> ===================================================================
> --- merge.orig/drivers/char/hvc_console.c
> +++ merge/drivers/char/hvc_console.c
> @@ -320,10 +320,8 @@ static int hvc_open(struct tty_struct *t
>  	struct kobject *kobjp;
>  
>  	/* Auto increments kobject reference if found. */
> -	if (!(hp = hvc_get_by_index(tty->index))) {
> -		printk(KERN_WARNING "hvc_console: tty open failed, no vty associated with tty.\n");
> +	if (!(hp = hvc_get_by_index(tty->index)))
>  		return -ENODEV;
> -	}
>  
>  	spin_lock_irqsave(&hp->lock, flags);
>  	/* Check and then increment for fast path open. */

This seems like a good fix to me.  I think it is a debug artifact
anyway.

-- 
Ryan S. Arnold <rsa@us.ibm.com>
IBM Linux Technology Center
Linux on Power Toolchain