From: Hollis Blanchard <hollisb@us.ibm.com>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: common flatdevtree code
Date: Thu, 07 Sep 2006 17:23:36 -0500 [thread overview]
Message-ID: <1157667816.5220.30.camel@basalt.austin.ibm.com> (raw)
In-Reply-To: <20060907182717.GC4398@mag.az.mvista.com>
On Thu, 2006-09-07 at 11:27 -0700, Mark A. Greer wrote:
>
> On Thu, Sep 07, 2006 at 02:43:31AM -0500, Hollis Blanchard wrote:
> >
> > On Wed, 2006-09-06 at 17:36 -0700, Mark A. Greer wrote:
> > > void *ft_find_device(const void *bphp, const char *srch_path)
> >
> > How about "ft_find_node"?
>
> Sure.
>
> > I renamed that and made a couple other small
> > changes. In particular:
> > - u8->int
>
> OK.
>
> > - exit and free -> ft_exit and ft_free (so they can be wrapped in
> > flatdevtree_env.h)
>
> Makes sense.
>
> > - moved those inlines out of flatdevtree.h, since they don't need to be
> > exported
>
> ft_parentize is also used in flatdevtree_misc.c so I think they
> should stay in flatdevtree.h.
OK.
I've pushed these changes and a couple more (run hg pull -u to update).
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2006-09-07 22:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 18:40 common flatdevtree code Mark A. Greer
2006-09-06 3:52 ` Paul Mackerras
2006-09-06 18:14 ` Mark A. Greer
2006-09-07 0:36 ` Mark A. Greer
2006-09-07 7:43 ` Hollis Blanchard
2006-09-07 18:27 ` Mark A. Greer
2006-09-07 22:23 ` Hollis Blanchard [this message]
2006-09-08 0:56 ` Mark A. Greer
2006-09-08 1:11 ` Mark A. Greer
2006-09-08 13:23 ` Paul Mackerras
2006-09-08 16:51 ` Mark A. Greer
2006-09-19 19:45 ` Mark A. Greer
2006-09-27 22:32 ` Paul Mackerras
2006-09-27 22:55 ` Hollis Blanchard
2006-09-27 23:41 ` Segher Boessenkool
2006-09-27 23:52 ` Hollis Blanchard
2006-09-28 0:51 ` Segher Boessenkool
2006-09-28 19:34 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157667816.5220.30.camel@basalt.austin.ibm.com \
--to=hollisb@us.ibm.com \
--cc=Linuxppc-dev@ozlabs.org \
--cc=mgreer@mvista.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).