From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 0303067B97 for ; Fri, 8 Sep 2006 09:31:04 +1000 (EST) Subject: Re: [Fwd: Re: ohci1394: steps to implement suspend/resume] From: Benjamin Herrenschmidt To: Stefan Richter In-Reply-To: <4500743D.9000403@s5r6.in-berlin.de> References: <44FEDF5D.9060707@s5r6.in-berlin.de> <1157590416.22705.269.camel@localhost.localdomain> <4500743D.9000403@s5r6.in-berlin.de> Content-Type: text/plain Date: Fri, 08 Sep 2006 09:30:41 +1000 Message-Id: <1157671842.22705.340.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, linux1394-devel@lists.sourceforge.net, Bernhard Kaindl , Pavel Machek List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2006-09-07 at 21:34 +0200, Stefan Richter wrote: > Benjamin Herrenschmidt wrote: > > On Wed, 2006-09-06 at 16:46 +0200, Stefan Richter wrote: > [...] > >> We already broke your platform code once by what was meant as a bugfix > >> for non-PMacs. It'd be good to know enough to not repeat such mistakes... > > > > The PowerMac code will stop the chip clocks. It should be used as the > > last step of the suspend sequence and first step of the return sequence, > > in _addition_ to your new code. > > Thanks for the help. np. I'll try to test if I find some time :) Ben.