From: Michael Ellerman <michael@ellerman.id.au>
To: mohan@in.ibm.com
Cc: linuxppc-dev@ozlabs.org, mingo@elte.hu, paulus@samba.org,
torvalds@osdl.org, fastboot@osdl.org
Subject: Re: Fix interrupt clearing in kdump shutdown sequence
Date: Thu, 14 Sep 2006 13:07:29 +1000 [thread overview]
Message-ID: <1158203250.7305.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20060912121821.GB20606@in.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 821 bytes --]
On Tue, 2006-09-12 at 17:48 +0530, Mohan Kumar M wrote:
> Hi,
>
> Some times HVC console on a PPC machine may have pending interrupts and
> in this case kdump shutdown sequence created problem by calling
> chip->end. This should be chip->eoi(). The attached patch fixes this
> issue. Tested on POWER5 box.
Nice catch.
Looks like chip->end() used to == xics_end_irq(), but that vanished and
became xics_eio_(direct|lpar) and got hooked up to chip->eoi(). We
should check there are no other callers of chip->end() which really want
chip->eoi().
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
prev parent reply other threads:[~2006-09-14 3:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-12 12:18 Fix interrupt clearing in kdump shutdown sequence Mohan Kumar M
2006-09-14 3:07 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158203250.7305.11.camel@localhost.localdomain \
--to=michael@ellerman.id.au \
--cc=fastboot@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=mohan@in.ibm.com \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).