From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: akpm@osdl.org, Stephen Rothwell <sfr@canb.auug.org.au>,
netdev@vger.kernel.org, jgarzik@pobox.com,
ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: Fw: [PATCH] Remove powerpc specific parts of 3c509 driver
Date: Wed, 20 Sep 2006 09:18:38 +1000 [thread overview]
Message-ID: <1158707918.6002.179.camel@localhost.localdomain> (raw)
In-Reply-To: <20060919184243.GL29167@austin.ibm.com>
> However, I presume someone added the __powerpc__ define here
> because they picked up a 3c509 at a garage sale, stuck it in
> a powerpc, found out it didn't work due to a byte-swapping bug,
> and then patched it as above. I'm disturbed that somehow
> outsl_ns() became identical to outsl() at some point, presumably
> breaking this patch.
The problem is that somebody had the "bright" idea to implement ppc
outsl as byteswapping a loooong time ago. This was totally bogus and got
fixed, but it looks like this driver holds a remain of that period.
Ben.
next prev parent reply other threads:[~2006-09-19 23:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 4:54 Fw: [PATCH] Remove powerpc specific parts of 3c509 driver Stephen Rothwell
2006-09-19 18:42 ` Linas Vepstas
2006-09-19 18:52 ` Matt Sealey
2006-09-19 19:44 ` Linas Vepstas
2006-09-19 23:24 ` Benjamin Herrenschmidt
2006-09-20 0:21 ` Segher Boessenkool
2006-09-20 0:25 ` Benjamin Herrenschmidt
2006-09-20 0:58 ` Segher Boessenkool
2006-09-20 1:17 ` Linas Vepstas
2006-09-20 1:41 ` Segher Boessenkool
2006-09-20 0:57 ` Jeff Garzik
2006-09-20 1:08 ` Segher Boessenkool
2006-09-20 1:18 ` Jeff Garzik
2006-09-20 20:06 ` Segher Boessenkool
2006-09-20 21:29 ` Jeff Garzik
2006-09-19 23:18 ` Benjamin Herrenschmidt [this message]
2006-09-19 23:27 ` Fw: " Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158707918.6002.179.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linas@austin.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).