From: Hollis Blanchard <hollisb@us.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [POWERPC] merge iSeries i/o operations with the rest
Date: Wed, 20 Sep 2006 11:01:36 -0500 [thread overview]
Message-ID: <1158768096.19375.6.camel@basalt.austin.ibm.com> (raw)
In-Reply-To: <20060920221558.1322b8b4.sfr@canb.auug.org.au>
On Wed, 2006-09-20 at 22:15 +1000, Stephen Rothwell wrote:
> + if (firmware_has_feature(FW_FEATURE_ISERIES)) {
> + BUG();
> + return;
> + }
Shouldn't all these be BUG_ON(firmware_has_feature(FW_FEATURE_ISERIES))?
--
Hollis Blanchard
IBM Linux Technology Center
next prev parent reply other threads:[~2006-09-20 16:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-05 2:08 [POWERPC] merge iSeries i/o operations with the rest Stephen Rothwell
2006-09-05 5:07 ` David Woodhouse
2006-09-05 5:39 ` Stephen Rothwell
2006-09-05 16:41 ` Linas Vepstas
2006-09-05 23:19 ` Stephen Rothwell
2006-09-06 8:24 ` Stephen Rothwell
2006-09-18 5:38 ` Stephen Rothwell
2006-09-20 12:15 ` Stephen Rothwell
2006-09-20 16:01 ` Hollis Blanchard [this message]
2006-09-21 0:03 ` Stephen Rothwell
2006-09-21 0:20 ` Michael Ellerman
2006-09-21 4:55 ` [POWERPC] mark BUG() as noreturn Stephen Rothwell
2006-09-21 12:18 ` Jimi Xenidis
2006-09-22 0:54 ` Michael Ellerman
2006-09-22 1:34 ` Amos Waterland
2006-09-22 10:58 ` Jimi Xenidis
2006-09-21 13:23 ` David Howells
2006-09-21 15:15 ` Segher Boessenkool
2006-09-21 8:00 ` [POWERPC] merge iSeries i/o operations with the rest Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158768096.19375.6.camel@basalt.austin.ibm.com \
--to=hollisb@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).