Re: [POWERPC] merge iSeries i/o operations with the rest

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

On Thu, 2006-09-21 at 10:03 +1000, Stephen Rothwell wrote:
> Hi Hollis,
> 
> On Wed, 20 Sep 2006 11:01:36 -0500 Hollis Blanchard <hollisb@us.ibm.com> wrote:
> >
> > On Wed, 2006-09-20 at 22:15 +1000, Stephen Rothwell wrote:
> > > +       if (firmware_has_feature(FW_FEATURE_ISERIES)) {
> > > +               BUG();
> > > +               return;
> > > +       }
> > 
> > Shouldn't all these be BUG_ON(firmware_has_feature(FW_FEATURE_ISERIES))?
> 
> In this case, the return helps because the compiler will not generate the
> following code in iSeries only builds.  If we could tell the compiler
> that BUG() and BUG_ON() won't return, then BUG_ON() would be better.

Just put a return in the BUG_ON() macro ;D

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]