From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pentafluge.infradead.org (pentafluge.infradead.org [213.146.154.40]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 2DCE267BC7 for ; Mon, 2 Oct 2006 19:42:36 +1000 (EST) Subject: Re: [PATCH] Use check_legacy_ioport() for ISAPnP From: David Woodhouse To: Olaf Hering In-Reply-To: <20061002093853.GA13880@aepfle.de> References: <1159341535.3309.108.camel@pmac.infradead.org> <20060927081838.GA5984@aepfle.de> <1159361385.3309.118.camel@pmac.infradead.org> <20060927130525.GA7550@aepfle.de> <20061002093853.GA13880@aepfle.de> Content-Type: text/plain Date: Mon, 02 Oct 2006 10:42:04 +0100 Message-Id: <1159782124.4801.10.camel@pmac.infradead.org> Mime-Version: 1.0 Cc: paulus@samba.org, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2006-10-02 at 11:38 +0200, Olaf Hering wrote: > > The new check in parport_pc_init() will prevent the probing of PCI > devices. I guess the correct fix would be a sophisticated > pmac_check_legacy_ioport() that checks if baseport is available on > some PCI device: That or only call check_legacy_ioport() when we're poking _gratuitously_ at legacy space, not when there's a properly-detected port. -- dwmw2