From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41pzD861TTzDrYj for ; Tue, 14 Aug 2018 00:50:16 +1000 (AEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7DEdeCG110624 for ; Mon, 13 Aug 2018 10:50:14 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kub31u2fx-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 13 Aug 2018 10:50:13 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Aug 2018 15:50:10 +0100 Subject: Re: [PATCH V2] ocxl: Fix access to the AFU Descriptor Data To: Christophe Lombard , linuxppc-dev@lists.ozlabs.org, fbarrat@linux.vnet.ibm.com, vaibhav@linux.vnet.ibm.com, andrew.donnellan@au1.ibm.com References: <1534169362-9394-1-git-send-email-clombard@linux.vnet.ibm.com> From: Frederic Barrat Date: Mon, 13 Aug 2018 16:50:05 +0200 MIME-Version: 1.0 In-Reply-To: <1534169362-9394-1-git-send-email-clombard@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <115b11c1-00de-f169-977c-b864405e2435@linux.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 13/08/2018 à 16:09, Christophe Lombard a écrit : > The AFU Information DVSEC capability is a means to extract common, > general information about all of the AFUs associated with a Function > independent of the specific functionality that each AFU provides. > > This patch fixes the access to the AFU Descriptor Data indexed by the > AFU Info Index field. > > Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") > Cc: stable # 4.16 > Signed-off-by: Christophe Lombard > --- Thanks! Acked-by: Frederic Barrat > Changelog[v2] > - Rebase to latest upstream. > - Use pci_write_config_byte instead of pci_write_config_word > --- > drivers/misc/ocxl/config.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > index 2e30de9..57a6bb1 100644 > --- a/drivers/misc/ocxl/config.c > +++ b/drivers/misc/ocxl/config.c > @@ -280,7 +280,9 @@ int ocxl_config_check_afu_index(struct pci_dev *dev, > u32 val; > int rc, templ_major, templ_minor, len; > > - pci_write_config_word(dev, fn->dvsec_afu_info_pos, afu_idx); > + pci_write_config_byte(dev, > + fn->dvsec_afu_info_pos + OCXL_DVSEC_AFU_INFO_AFU_IDX, > + afu_idx); > rc = read_afu_info(dev, fn, OCXL_DVSEC_TEMPL_VERSION, &val); > if (rc) > return rc; >