From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Eugene Surovegin <ebs@ebshome.net>
Cc: Olof Johansson <olof@lixom.net>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 10/11] Add MPC8360EMDS board support
Date: Thu, 05 Oct 2006 16:26:34 +1000 [thread overview]
Message-ID: <1160029594.22232.22.camel@localhost.localdomain> (raw)
In-Reply-To: <20061005062105.GA1985@gate.ebshome.net>
On Wed, 2006-10-04 at 23:21 -0700, Eugene Surovegin wrote:
> On Thu, Oct 05, 2006 at 09:36:59AM +1000, Benjamin Herrenschmidt wrote:
> > Ugh ? Look at the #ifdef mess in ibm_emac...
>
> Ugh?
>
> I think you have to thank IBM/AMCC designers which keep changing bit
> layout of some registers, sometimes just changing polarity for no
> reason.
>
> And with all due respect, Ben. Current ibm_emac despite of all "mess"
> is actually usable in production environment, which cannot be said
> about initial Armin version and second version you started but never
> got time to actually finish.
That second version was working fine... on the limited available
variations of EMAC back then.
Regarding the "mess", it's the whole #ifdef junk in there that is
driving me nuts and that I'll rip appart probably next week. A lot of
this could be soft-tests or the ifdefs could be resolved at Kconfig
instead of having a list of processors in 3 different headers if you
really want to compile the changes in rather than do soft-tests.
Ben.
next prev parent reply other threads:[~2006-10-05 6:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 12:20 [PATCH 10/11] Add MPC8360EMDS board support Li Yang
2006-09-27 6:39 ` Paul Mackerras
2006-09-27 11:56 ` Vitaly Bordug
2006-09-27 12:02 ` Li Yang-r58472
2006-09-27 12:55 ` Vitaly Bordug
2006-09-27 13:09 ` Ben Warren
2006-09-27 13:20 ` Li Yang-r58472
2006-09-27 13:33 ` Kumar Gala
2006-09-28 6:12 ` Li Yang-r58472
2006-09-30 0:49 ` Paul Mackerras
2006-09-27 14:14 ` Jon Loeliger
2006-09-28 6:38 ` Li Yang-r58472
2006-09-27 14:42 ` Dan Malek
2006-09-27 16:22 ` Olof Johansson
2006-09-28 4:10 ` Dan Malek
2006-09-30 15:56 ` Li Yang
2006-10-04 0:40 ` Paul Mackerras
2006-10-04 13:53 ` Dan Malek
2006-10-04 17:28 ` Tim Bird
2006-10-05 0:27 ` Paul Mackerras
2006-10-05 6:29 ` Eugene Surovegin
2006-10-04 6:08 ` Benjamin Herrenschmidt
2006-10-04 14:48 ` Dan Malek
2006-10-04 23:36 ` Benjamin Herrenschmidt
2006-10-05 0:03 ` Paul Mackerras
2006-10-05 0:08 ` Benjamin Herrenschmidt
2006-10-05 0:16 ` Vitaly Bordug
2006-10-05 6:21 ` Eugene Surovegin
2006-10-05 6:26 ` Benjamin Herrenschmidt [this message]
2006-10-05 6:31 ` Eugene Surovegin
2006-10-05 6:33 ` Eugene Surovegin
2006-10-05 6:51 ` Benjamin Herrenschmidt
2006-10-04 5:52 ` Benjamin Herrenschmidt
2006-10-04 14:57 ` Dan Malek
2006-10-04 16:05 ` Jerry Van Baren
2006-09-27 14:57 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2006-09-27 13:54 Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160029594.22232.22.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=ebs@ebshome.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).