From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Lynch <ntl@pobox.com>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: make U4 PCIe work
Date: Fri, 06 Oct 2006 08:10:26 +1000 [thread overview]
Message-ID: <1160086226.22232.62.camel@localhost.localdomain> (raw)
In-Reply-To: <20061005170458.GL24705@localdomain>
> Do the changes to fixup_maple_ide have anything to do with the rest of
> the patch? It's not clear from your description. And with that last
> hunk the function now appears to do nothing.
Hrm... I could split that indeed. The last bits to fixup_maple_ide()
should no longer be necessary. They used to work around broken PIBS but
that should have been fixed a long time ago.
> Could we consider merging the powermac and maple pci code into a
> common location that would be used by both platforms? There's quite a
> bit of code duplication going on here...
A bit but not exactly... I may do it but just not right now.
Ben.
next prev parent reply other threads:[~2006-10-05 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 4:54 [PATCH] powerpc: make U4 PCIe work Benjamin Herrenschmidt
2006-10-05 17:04 ` Nathan Lynch
2006-10-05 22:10 ` Benjamin Herrenschmidt [this message]
2006-10-05 18:45 ` Segher Boessenkool
2006-10-05 22:26 ` Benjamin Herrenschmidt
2006-10-05 22:52 ` Nathan Lynch
2006-10-05 23:37 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160086226.22232.62.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).