linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: [PATCH 1/5] powerpc: consolidate feature fixup code
Date: Mon, 16 Oct 2006 14:51:26 +1000	[thread overview]
Message-ID: <1160974286.22522.37.camel@localhost.localdomain> (raw)
In-Reply-To: <1160726663.4792.222.camel@localhost.localdomain>

On Fri, 2006-10-13 at 18:04 +1000, Benjamin Herrenschmidt wrote:
>  
> Index: linux-cell/include/asm-powerpc/system.h
> ===================================================================
> --- linux-cell.orig/include/asm-powerpc/system.h        2006-10-06 13:48:24.000000000 +1000
> +++ linux-cell/include/asm-powerpc/system.h     2006-10-13 16:24:45.000000000 +1000
> @@ -378,7 +378,11 @@ extern unsigned long reloc_offset(void);
>  extern unsigned long add_reloc_offset(unsigned long);
>  extern void reloc_got2(unsigned long);
>  
> +#ifdef CONFIG_PPC64
> +#define PTRRELOC(x)    x
> +#else
>  #define PTRRELOC(x)    ((typeof(x)) add_reloc_offset((unsigned long)(x)))
> +#endif
>  
>  static inline void create_instruction(unsigned long addr, unsigned int instr)
>  {

And of course that bit of the patch is a stupid "optimisation" that
breaks prom_init.c on ppc64... I'll post a new patch without it and do
more tests (damn, I tested iSeries and figured if it worked there, it
would work everywhere :)

Ben.

  parent reply	other threads:[~2006-10-16  4:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-13  8:04 [PATCH 1/5] powerpc: consolidate feature fixup code Benjamin Herrenschmidt
2006-10-13 16:54 ` Olof Johansson
2006-10-13 22:36   ` Benjamin Herrenschmidt
2006-10-14  2:01     ` Olof Johansson
2006-10-14  1:42   ` Stephen Rothwell
2006-10-14  1:58     ` Olof Johansson
2006-10-14  2:11 ` Olof Johansson
2006-10-16  4:51 ` Benjamin Herrenschmidt [this message]
2006-10-16  6:25   ` [PATCH 1/5] powerpc: consolidate feature fixup code #2 Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2006-10-20  1:47 [PATCH 1/5] powerpc: consolidate feature fixup code Benjamin Herrenschmidt
2006-10-20  2:00 ` Olof Johansson
2006-10-23 10:40 ` Paul Mackerras
2006-10-23 21:12   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1160974286.22522.37.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).