* ibmveth and LIOBN field
@ 2006-10-18 5:41 Benjamin Herrenschmidt
2006-10-18 16:14 ` Santiago Leon
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-18 5:41 UTC (permalink / raw)
To: Santiago Leon; +Cc: linuxppc-dev list, Paul Mackerras, David Gibson
Hi Santiago !
I'm a bit annoyed by a bit of code in the ibmveth driver:
It accesses the iommu table pointer, to get the index and put it into
it's own private adapter->liobn member. However, that is never used
anywhere except in ibmveth_seq_show() for the /proc stuff to display
this LIOBN value.
Is this actually useful ? I'd like to just remove that code. I'm
changing the DMA operations management globally in the powerpc
architecture and that code now needs fixups. I've done them, but it
annoys me to have this driver dive into data structures like iommu_table
that is should have no business mucking with.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ibmveth and LIOBN field
2006-10-18 5:41 ibmveth and LIOBN field Benjamin Herrenschmidt
@ 2006-10-18 16:14 ` Santiago Leon
0 siblings, 0 replies; 2+ messages in thread
From: Santiago Leon @ 2006-10-18 16:14 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev list, David Gibson, Paul Mackerras
Benjamin Herrenschmidt wrote:
> Hi Santiago !
>
> I'm a bit annoyed by a bit of code in the ibmveth driver:
>
> It accesses the iommu table pointer, to get the index and put it into
> it's own private adapter->liobn member. However, that is never used
> anywhere except in ibmveth_seq_show() for the /proc stuff to display
> th'is LIOBN value.
>
> Is this actually useful ? I'd like to just remove that code.
I'll gladly sign off a patch that removes that code. I think we used
liobn in the driver a long time ago to do the tce mappings before we
merged all the common virtual io code into arch/powerpc/vio.c.
--
Santiago A. Leon
Power Linux Development
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-18 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-18 5:41 ibmveth and LIOBN field Benjamin Herrenschmidt
2006-10-18 16:14 ` Santiago Leon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).