From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 5766167A2E for ; Tue, 24 Oct 2006 17:40:23 +1000 (EST) Subject: Re: pci_set_power_state() failure and breaking suspend From: Benjamin Herrenschmidt To: linux1394-devel@lists.sourceforge.net In-Reply-To: <1161672898.10524.596.camel@localhost.localdomain> References: <1161672898.10524.596.camel@localhost.localdomain> Content-Type: text/plain Date: Tue, 24 Oct 2006 17:40:11 +1000 Message-Id: <1161675611.10524.598.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev list , Linux Kernel list , Greg KH List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2006-10-24 at 16:54 +1000, Benjamin Herrenschmidt wrote: > So I noticed a small regression that I think might uncover a deeper > issue... > > Recently, ohci1394 grew some "proper" error handling in its suspend > function, something that looks like: > > err = pci_set_power_state(pdev, pci_choose_state(pdev, state)); > if (err) > goto out; > > First, it breaks some old PowerBooks where the internal OHCI had PM > feature exposed on PCI (the pmac specific code that follows those lines > is enough on those machines). If I could type, the above would have read... First, it breaks some old PowerBooks where the internal OHCI has no PM feature exposed on PCI.... Ben.