linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Mark A. Greer" <mgreer@mvista.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>
Subject: Re: [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only
Date: Thu, 26 Oct 2006 10:06:16 +1000	[thread overview]
Message-ID: <1161821177.22582.149.camel@localhost.localdomain> (raw)
In-Reply-To: <20061025233649.GB17461@mag.az.mvista.com>

On Wed, 2006-10-25 at 16:36 -0700, Mark A. Greer wrote:
> Currently, early_init() in setup_32.c zeroes from '_bss_start' to '_end'.
> It should only zero from '__bss_start' to '__bss_stop'.  This patch does that.
> 
> Signed-off-by: Mark A. Greer <mgreer@mvista.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

> 
>  setup_32.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletion(-)
> ---
> 
> diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
> index a4c2964..c682e9a 100644
> --- a/arch/powerpc/kernel/setup_32.c
> +++ b/arch/powerpc/kernel/setup_32.c
> @@ -95,7 +95,8 @@ unsigned long __init early_init(unsigned
>  
>  	/* First zero the BSS -- use memset_io, some platforms don't have
>  	 * caches on yet */
> -	memset_io((void __iomem *)PTRRELOC(&__bss_start), 0, _end - __bss_start);
> +	memset_io((void __iomem *)PTRRELOC(&__bss_start), 0,
> +			__bss_stop - __bss_start);
>  
>  	/*
>  	 * Identify the CPU type and fix up code sections
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

  reply	other threads:[~2006-10-26  0:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 23:36 [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only Mark A. Greer
2006-10-26  0:06 ` Benjamin Herrenschmidt [this message]
2007-03-16  4:30   ` Mark A. Greer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1161821177.22582.149.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=mgreer@mvista.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).