* [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only
@ 2006-10-25 23:36 Mark A. Greer
2006-10-26 0:06 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Mark A. Greer @ 2006-10-25 23:36 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
Currently, early_init() in setup_32.c zeroes from '_bss_start' to '_end'.
It should only zero from '__bss_start' to '__bss_stop'. This patch does that.
Signed-off-by: Mark A. Greer <mgreer@mvista.com>
---
setup_32.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
index a4c2964..c682e9a 100644
--- a/arch/powerpc/kernel/setup_32.c
+++ b/arch/powerpc/kernel/setup_32.c
@@ -95,7 +95,8 @@ unsigned long __init early_init(unsigned
/* First zero the BSS -- use memset_io, some platforms don't have
* caches on yet */
- memset_io((void __iomem *)PTRRELOC(&__bss_start), 0, _end - __bss_start);
+ memset_io((void __iomem *)PTRRELOC(&__bss_start), 0,
+ __bss_stop - __bss_start);
/*
* Identify the CPU type and fix up code sections
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only
2006-10-25 23:36 [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only Mark A. Greer
@ 2006-10-26 0:06 ` Benjamin Herrenschmidt
2007-03-16 4:30 ` Mark A. Greer
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-26 0:06 UTC (permalink / raw)
To: Mark A. Greer; +Cc: linuxppc-dev, Paul Mackerras
On Wed, 2006-10-25 at 16:36 -0700, Mark A. Greer wrote:
> Currently, early_init() in setup_32.c zeroes from '_bss_start' to '_end'.
> It should only zero from '__bss_start' to '__bss_stop'. This patch does that.
>
> Signed-off-by: Mark A. Greer <mgreer@mvista.com>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> setup_32.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletion(-)
> ---
>
> diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
> index a4c2964..c682e9a 100644
> --- a/arch/powerpc/kernel/setup_32.c
> +++ b/arch/powerpc/kernel/setup_32.c
> @@ -95,7 +95,8 @@ unsigned long __init early_init(unsigned
>
> /* First zero the BSS -- use memset_io, some platforms don't have
> * caches on yet */
> - memset_io((void __iomem *)PTRRELOC(&__bss_start), 0, _end - __bss_start);
> + memset_io((void __iomem *)PTRRELOC(&__bss_start), 0,
> + __bss_stop - __bss_start);
>
> /*
> * Identify the CPU type and fix up code sections
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only
2006-10-26 0:06 ` Benjamin Herrenschmidt
@ 2007-03-16 4:30 ` Mark A. Greer
0 siblings, 0 replies; 3+ messages in thread
From: Mark A. Greer @ 2007-03-16 4:30 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev
Paul,
This one was dropped somewhere along the way...
Mark
---
On Thu, Oct 26, 2006 at 10:06:16AM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2006-10-25 at 16:36 -0700, Mark A. Greer wrote:
> > Currently, early_init() in setup_32.c zeroes from '_bss_start' to '_end'.
> > It should only zero from '__bss_start' to '__bss_stop'. This patch does that.
> >
> > Signed-off-by: Mark A. Greer <mgreer@mvista.com>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> >
> > setup_32.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletion(-)
> > ---
> >
> > diff --git a/arch/powerpc/kernel/setup_32.c b/arch/powerpc/kernel/setup_32.c
> > index a4c2964..c682e9a 100644
> > --- a/arch/powerpc/kernel/setup_32.c
> > +++ b/arch/powerpc/kernel/setup_32.c
> > @@ -95,7 +95,8 @@ unsigned long __init early_init(unsigned
> >
> > /* First zero the BSS -- use memset_io, some platforms don't have
> > * caches on yet */
> > - memset_io((void __iomem *)PTRRELOC(&__bss_start), 0, _end - __bss_start);
> > + memset_io((void __iomem *)PTRRELOC(&__bss_start), 0,
> > + __bss_stop - __bss_start);
> >
> > /*
> > * Identify the CPU type and fix up code sections
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-03-16 4:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-25 23:36 [POWERPC] 32-bit early_init() should zero from __bss_start to __bss_stop only Mark A. Greer
2006-10-26 0:06 ` Benjamin Herrenschmidt
2007-03-16 4:30 ` Mark A. Greer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).