From: Michael Neuling <mikey@neuling.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
Jeremy Kerr <jk@ozlabs.org>,
cbe-oss-dev@ozlabs.org
Subject: Re: [Cbe-oss-dev] [PATCH] powerpc/cell: disable ptcal in case of kdump reboot
Date: Thu, 12 Jun 2008 18:06:54 +1000 [thread overview]
Message-ID: <11619.1213258014@neuling.org> (raw)
In-Reply-To: <200806120939.23836.arnd@arndb.de>
In message <200806120939.23836.arnd@arndb.de> you wrote:
> On Wednesday 11 June 2008, Michael Ellerman wrote:
> > On Wed, 2008-06-11 at 18:28 +0200, Arnd Bergmann wrote:
> > > We used to do this correctly in case of a user triggered
> > > kexec, but not for kdump.
> >
> > Used to?
>
> Sorry, wrong wording. I meant without this patch, it's correct
> for kexec.
>
> > > This patch disables ptcal from the cell specific
> > > machine_crash_shutdown() callback.
> >
> > I'd rather you used the crash_shutdown_register() infrastructure Mikey
> > added for EHEA - it's designed for just this sort of thing.
>
> Thanks for pointing this out, I wasn't aware of that call.
> New patch coming up.
In theory we can register lots of call backs but currently the maximum
is set to 1 through CRASH_HANDLER_MAX. This is to discourage people
from using this infrastructure at all.
Unless there's some crazy arse company that's going to mix a CBE with an
eHEA, we are probably ok leaving this at 1. Right?
Mikey
next prev parent reply other threads:[~2008-06-12 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-11 16:28 [PATCH] powerpc/cell: disable ptcal in case of kdump reboot Arnd Bergmann
2008-06-11 16:34 ` please pull merge branch of cell-2.6.git Arnd Bergmann
2008-06-11 16:49 ` [Cbe-oss-dev] [PATCH] powerpc/cell: disable ptcal in case of kdump reboot Michael Ellerman
2008-06-12 7:39 ` Arnd Bergmann
2008-06-12 8:06 ` Michael Neuling [this message]
2008-06-12 9:04 ` Michael Ellerman
2008-06-12 11:22 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11619.1213258014@neuling.org \
--to=mikey@neuling.org \
--cc=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=jk@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).