From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mikey@neuling.org>
From: Michael Neuling <mikey@neuling.org>
To: Arnd Bergmann <arnd@arndb.de>
Subject: Re: [Cbe-oss-dev] [PATCH] powerpc/cell: disable ptcal in case of
	kdump reboot
In-reply-to: <200806120939.23836.arnd@arndb.de> 
References: <200806111828.59043.arnd@arndb.de>
	<1213202956.28589.4.camel@localhost>
	<200806120939.23836.arnd@arndb.de>
Date: Thu, 12 Jun 2008 18:06:54 +1000
Message-ID: <11619.1213258014@neuling.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
	Jeremy Kerr <jk@ozlabs.org>, cbe-oss-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

In message <200806120939.23836.arnd@arndb.de> you wrote:
> On Wednesday 11 June 2008, Michael Ellerman wrote:
> > On Wed, 2008-06-11 at 18:28 +0200, Arnd Bergmann wrote:
> > > We used to do this correctly in case of a user triggered
> > > kexec, but not for kdump.
> > 
> > Used to?
> 
> Sorry, wrong wording. I meant without this patch, it's correct
> for kexec.
>  
> > > This patch disables ptcal from the cell specific
> > > machine_crash_shutdown() callback. 
> > 
> > I'd rather you used the crash_shutdown_register() infrastructure Mikey
> > added for EHEA - it's designed for just this sort of thing.
> 
> Thanks for pointing this out, I wasn't aware of that call.
> New patch coming up.

In theory we can register lots of call backs but currently the maximum
is set to 1 through CRASH_HANDLER_MAX.  This is to discourage people
from using this infrastructure at all.

Unless there's some crazy arse company that's going to mix a CBE with an
eHEA, we are probably ok leaving this at 1.  Right?

Mikey