From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@gmail.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [POWERPC] Cleanup pegasos i8259 not in device tree workaround.
Date: Sat, 28 Oct 2006 07:44:10 +1000 [thread overview]
Message-ID: <1161985450.25682.75.camel@localhost.localdomain> (raw)
In-Reply-To: <116196732980-git-send-email-grant.likely@gmail.com>
On Fri, 2006-10-27 at 10:42 -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Only make assumptions about i8259 presence if ppc_md.get_irq is not set.
> Previous workaround only checked chrp_mpic value.
>
> Nicolas, please verify that this patch fixes your mpc52xx pic problems.
> Ben, I got tired of how often this question was being raised, so I just
> wrote this patch; I've compiled, but cannot test it.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/platforms/chrp/setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c
> index 49b8dab..a5466ed 100644
> --- a/arch/powerpc/platforms/chrp/setup.c
> +++ b/arch/powerpc/platforms/chrp/setup.c
> @@ -451,7 +451,7 @@ static void __init chrp_find_8259(void)
> * we have a pegasos that claims to be chrp but doesn't have
> * a proper interrupt tree
> */
> - if (pic == NULL && chrp_mpic != NULL) {
> + if (pic == NULL && ppc_md.get_irq != NULL) {
> printk(KERN_ERR "i8259: Not found in device-tree"
> " assuming no legacy interrupts\n");
> return;
prev parent reply other threads:[~2006-10-27 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-27 16:42 [POWERPC] Cleanup pegasos i8259 not in device tree workaround Grant Likely
2006-10-27 21:44 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161985450.25682.75.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=grant.likely@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).