* [POWERPC] Cleanup pegasos i8259 not in device tree workaround.
@ 2006-10-27 16:42 Grant Likely
2006-10-27 21:44 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Grant Likely @ 2006-10-27 16:42 UTC (permalink / raw)
To: Nicolas DET, Benjamin Herrenschmidt, linuxppc-dev
From: Grant Likely <grant.likely@secretlab.ca>
Only make assumptions about i8259 presence if ppc_md.get_irq is not set.
Previous workaround only checked chrp_mpic value.
Nicolas, please verify that this patch fixes your mpc52xx pic problems.
Ben, I got tired of how often this question was being raised, so I just
wrote this patch; I've compiled, but cannot test it.
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/platforms/chrp/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c
index 49b8dab..a5466ed 100644
--- a/arch/powerpc/platforms/chrp/setup.c
+++ b/arch/powerpc/platforms/chrp/setup.c
@@ -451,7 +451,7 @@ static void __init chrp_find_8259(void)
* we have a pegasos that claims to be chrp but doesn't have
* a proper interrupt tree
*/
- if (pic == NULL && chrp_mpic != NULL) {
+ if (pic == NULL && ppc_md.get_irq != NULL) {
printk(KERN_ERR "i8259: Not found in device-tree"
" assuming no legacy interrupts\n");
return;
--
1.4.3.rc2.g0503
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [POWERPC] Cleanup pegasos i8259 not in device tree workaround.
2006-10-27 16:42 [POWERPC] Cleanup pegasos i8259 not in device tree workaround Grant Likely
@ 2006-10-27 21:44 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-10-27 21:44 UTC (permalink / raw)
To: Grant Likely; +Cc: linuxppc-dev
On Fri, 2006-10-27 at 10:42 -0600, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Only make assumptions about i8259 presence if ppc_md.get_irq is not set.
> Previous workaround only checked chrp_mpic value.
>
> Nicolas, please verify that this patch fixes your mpc52xx pic problems.
> Ben, I got tired of how often this question was being raised, so I just
> wrote this patch; I've compiled, but cannot test it.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> arch/powerpc/platforms/chrp/setup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/platforms/chrp/setup.c b/arch/powerpc/platforms/chrp/setup.c
> index 49b8dab..a5466ed 100644
> --- a/arch/powerpc/platforms/chrp/setup.c
> +++ b/arch/powerpc/platforms/chrp/setup.c
> @@ -451,7 +451,7 @@ static void __init chrp_find_8259(void)
> * we have a pegasos that claims to be chrp but doesn't have
> * a proper interrupt tree
> */
> - if (pic == NULL && chrp_mpic != NULL) {
> + if (pic == NULL && ppc_md.get_irq != NULL) {
> printk(KERN_ERR "i8259: Not found in device-tree"
> " assuming no legacy interrupts\n");
> return;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-27 21:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-27 16:42 [POWERPC] Cleanup pegasos i8259 not in device tree workaround Grant Likely
2006-10-27 21:44 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).