From: Michael Ellerman <michael@ellerman.id.au>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: Is get_property() correct?
Date: Sat, 28 Oct 2006 19:08:23 +1000 [thread overview]
Message-ID: <1162026503.14822.5.camel@localhost.localdomain> (raw)
In-Reply-To: <528646bc0610280038x421014bdxde263c5399907fcb@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Sat, 2006-10-28 at 01:38 -0600, Grant Likely wrote:
> On 10/28/06, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> > On Sat, 2006-10-28 at 00:41 -0600, Grant Likely wrote:
> >
> > Well considering that we don't know the type of the property value, the
> > best we can do is return a pointer to it ...
> >
> > The comment might want an update, though it never stroke me as confusing
> > but heh :)
>
> No, it's not confusing. Both the comment and the code are correct. I
> just forgot how to read code. :(
But at least now we're all _sure_ they're correct, some good still
done :)
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-10-28 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 6:41 Is get_property() correct? Grant Likely
2006-10-28 6:53 ` Michael Ellerman
2006-10-28 7:17 ` Johannes Berg
2006-10-28 7:23 ` Grant Likely
2006-10-28 7:23 ` Benjamin Herrenschmidt
2006-10-28 7:38 ` Grant Likely
2006-10-28 9:08 ` Michael Ellerman [this message]
2006-10-30 2:05 ` unsubscribe Usha Rani Konudula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162026503.14822.5.camel@localhost.localdomain \
--to=michael@ellerman.id.au \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).