linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 12:55 [patch 00/16] powerpc cleanup patches s.hauer
@ 2006-11-02 12:56 ` s.hauer
  2006-11-02 14:58   ` Grant Likely
  2006-11-21 15:13   ` Grant Likely
  0 siblings, 2 replies; 20+ messages in thread
From: s.hauer @ 2006-11-02 12:56 UTC (permalink / raw)
  To: linuxppc-dev

remove EMBEDDED6xx Kconfig entry

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Index: linux-2.6/arch/powerpc/Kconfig
===================================================================
--- linux-2.6.orig/arch/powerpc/Kconfig
+++ linux-2.6/arch/powerpc/Kconfig
@@ -338,10 +338,6 @@ config PPC_MULTIPLATFORM
 	  RS/6000 machine, an Apple machine, or a PReP, CHRP,
 	  Maple or Cell-based machine.
 
-config EMBEDDED6xx
-	bool "Embedded 6xx/7xx/7xxx-based board"
-	depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
-
 config APUS
 	bool "Amiga-APUS"
 	depends on PPC32 && BROKEN

--
 Dipl.-Ing. Sascha Hauer | http://www.pengutronix.de
  Pengutronix - Linux Solutions for Science and Industry
    Handelsregister: Amtsgericht Hildesheim, HRA 2686
      Hannoversche Str. 2, 31134 Hildesheim, Germany
    Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 12:56 ` [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry s.hauer
@ 2006-11-02 14:58   ` Grant Likely
  2006-11-02 15:25     ` Sascha Hauer
  2006-11-02 15:32     ` Stephen Winiecki
  2006-11-21 15:13   ` Grant Likely
  1 sibling, 2 replies; 20+ messages in thread
From: Grant Likely @ 2006-11-02 14:58 UTC (permalink / raw)
  To: s.hauer@pengutronix.de; +Cc: linuxppc-dev

On 11/2/06, s.hauer@pengutronix.de <s.hauer@pengutronix.de> wrote:
> remove EMBEDDED6xx Kconfig entry
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
>
> Index: linux-2.6/arch/powerpc/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/Kconfig
> +++ linux-2.6/arch/powerpc/Kconfig
> @@ -338,10 +338,6 @@ config PPC_MULTIPLATFORM
>           RS/6000 machine, an Apple machine, or a PReP, CHRP,
>           Maple or Cell-based machine.
>
> -config EMBEDDED6xx
> -       bool "Embedded 6xx/7xx/7xxx-based board"
> -       depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
> -
>  config APUS
>         bool "Amiga-APUS"
>         depends on PPC32 && BROKEN
>
> --

If you do this, then where should embedded 6xx board ports go?  For
example; mpc52xx for which there are currently patches on the mailing
list.

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 14:58   ` Grant Likely
@ 2006-11-02 15:25     ` Sascha Hauer
  2006-11-02 15:55       ` Grant Likely
  2006-11-02 15:32     ` Stephen Winiecki
  1 sibling, 1 reply; 20+ messages in thread
From: Sascha Hauer @ 2006-11-02 15:25 UTC (permalink / raw)
  To: Grant Likely; +Cc: linuxppc-dev

On Thu, Nov 02, 2006 at 07:58:39AM -0700, Grant Likely wrote:
> On 11/2/06, s.hauer@pengutronix.de <s.hauer@pengutronix.de> wrote:
> >remove EMBEDDED6xx Kconfig entry
> >
> >Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> >Index: linux-2.6/arch/powerpc/Kconfig
> >===================================================================
> >--- linux-2.6.orig/arch/powerpc/Kconfig
> >+++ linux-2.6/arch/powerpc/Kconfig
> >@@ -338,10 +338,6 @@ config PPC_MULTIPLATFORM
> >          RS/6000 machine, an Apple machine, or a PReP, CHRP,
> >          Maple or Cell-based machine.
> >
> >-config EMBEDDED6xx
> >-       bool "Embedded 6xx/7xx/7xxx-based board"
> >-       depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
> >-
> > config APUS
> >        bool "Amiga-APUS"
> >        depends on PPC32 && BROKEN
> >
> >--
> 
> If you do this, then where should embedded 6xx board ports go?  For
> example; mpc52xx for which there are currently patches on the mailing
> list.

I'm too working on the mpc52xx (I have nothing to submit though at the
moment, because my port is mainly copy-paste from arch=ppc).
I put my stuff under platforms/mpc52xx. I did this mainly because Nikolas
states his board isn't 'embedded', but mine is. I think this shows there
more a historical difference than a technical difference between 'embedded'
and 'not embedded' boards.
I'm running my board as a normal MULTIPLATFORM board and it works just
fine.

Sascha


-- 
 Dipl.-Ing. Sascha Hauer | http://www.pengutronix.de
  Pengutronix - Linux Solutions for Science and Industry
    Handelsregister: Amtsgericht Hildesheim, HRA 2686
      Hannoversche Str. 2, 31134 Hildesheim, Germany
    Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 14:58   ` Grant Likely
  2006-11-02 15:25     ` Sascha Hauer
@ 2006-11-02 15:32     ` Stephen Winiecki
  2006-11-02 16:00       ` Sascha Hauer
  1 sibling, 1 reply; 20+ messages in thread
From: Stephen Winiecki @ 2006-11-02 15:32 UTC (permalink / raw)
  To: Grant Likely; +Cc: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]





linuxppc-dev-bounces+stevewin=us.ibm.com@ozlabs.org wrote on 11/02/2006
09:58:39 AM:

> On 11/2/06, s.hauer@pengutronix.de <s.hauer@pengutronix.de> wrote:
> > remove EMBEDDED6xx Kconfig entry
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > Index: linux-2.6/arch/powerpc/Kconfig
> > ===================================================================
> > --- linux-2.6.orig/arch/powerpc/Kconfig
> > +++ linux-2.6/arch/powerpc/Kconfig
> > @@ -338,10 +338,6 @@ config PPC_MULTIPLATFORM
> >           RS/6000 machine, an Apple machine, or a PReP, CHRP,
> >           Maple or Cell-based machine.
> >
> > -config EMBEDDED6xx
> > -       bool "Embedded 6xx/7xx/7xxx-based board"
> > -       depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
> > -
> >  config APUS
> >         bool "Amiga-APUS"
> >         depends on PPC32 && BROKEN
> >
> > --
>
> If you do this, then where should embedded 6xx board ports go?  For
> example; mpc52xx for which there are currently patches on the mailing
> list.
>
> g.
>
> --
> Grant Likely, B.Sc. P.Eng.
> Secret Lab Technologies Ltd.
> grant.likely@secretlab.ca
> (403) 399-0195
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

I also have a question about 750xx platforms.  I currently am looking at
adding platform code supporting IBM 750GX/CL eval boards.  Where would they
go - as well as others like Buckeye/Chestnut if/when they move over to
/powerpc?

[-- Attachment #2: Type: text/html, Size: 2158 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 15:25     ` Sascha Hauer
@ 2006-11-02 15:55       ` Grant Likely
  2006-11-02 22:13         ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 20+ messages in thread
From: Grant Likely @ 2006-11-02 15:55 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: linuxppc-dev

On 11/2/06, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Thu, Nov 02, 2006 at 07:58:39AM -0700, Grant Likely wrote:
> > On 11/2/06, s.hauer@pengutronix.de <s.hauer@pengutronix.de> wrote:
> > >remove EMBEDDED6xx Kconfig entry
> > >
> > >Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > >
> > >Index: linux-2.6/arch/powerpc/Kconfig
> > >===================================================================
> > >--- linux-2.6.orig/arch/powerpc/Kconfig
> > >+++ linux-2.6/arch/powerpc/Kconfig
> > >@@ -338,10 +338,6 @@ config PPC_MULTIPLATFORM
> > >          RS/6000 machine, an Apple machine, or a PReP, CHRP,
> > >          Maple or Cell-based machine.
> > >
> > >-config EMBEDDED6xx
> > >-       bool "Embedded 6xx/7xx/7xxx-based board"
> > >-       depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
> > >-
> > > config APUS
> > >        bool "Amiga-APUS"
> > >        depends on PPC32 && BROKEN
> > >
> > >--
> >
> > If you do this, then where should embedded 6xx board ports go?  For
> > example; mpc52xx for which there are currently patches on the mailing
> > list.
>
> I'm too working on the mpc52xx (I have nothing to submit though at the
> moment, because my port is mainly copy-paste from arch=ppc).
> I put my stuff under platforms/mpc52xx. I did this mainly because Nikolas
> states his board isn't 'embedded', but mine is. I think this shows there
> more a historical difference than a technical difference between 'embedded'
> and 'not embedded' boards.
> I'm running my board as a normal MULTIPLATFORM board and it works just
> fine.

Then perhaps Efika should also be under platforms/mpc52xx?

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 15:32     ` Stephen Winiecki
@ 2006-11-02 16:00       ` Sascha Hauer
  2006-11-02 20:49         ` Stephen Winiecki
  2006-11-02 22:25         ` Benjamin Herrenschmidt
  0 siblings, 2 replies; 20+ messages in thread
From: Sascha Hauer @ 2006-11-02 16:00 UTC (permalink / raw)
  To: Stephen Winiecki; +Cc: linuxppc-dev

On Thu, Nov 02, 2006 at 10:32:53AM -0500, Stephen Winiecki wrote:
> 
>    I also have a question about 750xx platforms.  I currently am looking at
>    adding platform code supporting IBM 750GX/CL eval boards.  Where would
>    they go - as well as others like Buckeye/Chestnut if/when they move over
>    to /powerpc?

I don't know - Lets wait for ben and others what they say about this
approach.
My intention with this patch is to try and motivate people to
integrate their machines as a part of the multiplatform support, because
it doesn't cost a thing.
The presence of the embedded6xx entry and the entries in the directory
itself makes people think (me too) that the multiplatform thing is only
for the big irons. I think it's better to unify the two ways of platform
support where it's possible.

Sascha

-- 
 Dipl.-Ing. Sascha Hauer | http://www.pengutronix.de
  Pengutronix - Linux Solutions for Science and Industry
    Handelsregister: Amtsgericht Hildesheim, HRA 2686
      Hannoversche Str. 2, 31134 Hildesheim, Germany
    Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 16:00       ` Sascha Hauer
@ 2006-11-02 20:49         ` Stephen Winiecki
  2006-11-02 22:30           ` Benjamin Herrenschmidt
  2006-11-02 22:25         ` Benjamin Herrenschmidt
  1 sibling, 1 reply; 20+ messages in thread
From: Stephen Winiecki @ 2006-11-02 20:49 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 2049 bytes --]






Sascha Hauer <s.hauer@pengutronix.de> wrote on 11/02/2006 11:00:09 AM:

> On Thu, Nov 02, 2006 at 10:32:53AM -0500, Stephen Winiecki wrote:
> >
> >    I also have a question about 750xx platforms.  I currently am
looking at
> >    adding platform code supporting IBM 750GX/CL eval boards.  Where
would
> >    they go - as well as others like Buckeye/Chestnut if/when they move
over
> >    to /powerpc?
>
> I don't know - Lets wait for ben and others what they say about this
> approach.
> My intention with this patch is to try and motivate people to
> integrate their machines as a part of the multiplatform support, because
> it doesn't cost a thing.
> The presence of the embedded6xx entry and the entries in the directory
> itself makes people think (me too) that the multiplatform thing is only
> for the big irons. I think it's better to unify the two ways of platform
> support where it's possible.
>
What exactly is the intent of PPC_MULTIPLATFORM - the current desc states
"Generic desktop/server/laptop" - which doesn't exactly scream 'embedded'
to me either.  I guess I saw embedded6xx as a 'catch-all' for everything
else.

I might be missing something - but when you removed EMBEDDED6xx from
powerpc/Kconfig in patch 8, and removed MPC7448HPC2 from
embedded6xx/Kconfig in patch 6 - where did you move the MPC7448HPC2 config
section to?  Is your thought that it will depend on PPC_MULTIPLATFORM now
as well?

This may be slightly off topic - but one other thing I have noticed that
the new boot wrapper script supports specific 'types' of zImage files
associated w/ 'MUTIPLATFORMS' (PSERIES, CHRP, PREP etc.) and uImage - which
is what I think the majority of 'embedded' platforms will use by defining
CONFIG_DEFAULT_UIMAGE.  For IBM boards with PIBS just 'normal' zImage ELF
files get loaded - I'm not sure if there should be another type
defined/supported for boards which don't fit necessarily into a
PSERIES/CHRP/PREP definition and also don't use uboot -
CONFIG_DEFAULT_ZIMAGE?


[-- Attachment #2: Type: text/html, Size: 2354 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 15:55       ` Grant Likely
@ 2006-11-02 22:13         ` Benjamin Herrenschmidt
  2006-11-03  9:12           ` Sascha Hauer
  0 siblings, 1 reply; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2006-11-02 22:13 UTC (permalink / raw)
  To: Grant Likely; +Cc: linuxppc-dev, Paul Mackerras


> Then perhaps Efika should also be under platforms/mpc52xx?

Classifying platforms by their processor might not be the best idea... I
makes some sense when those platforms are basically reference designs
for the said processor but I yet have to be convinced it's really a good
thing in the long run :)

There will be a lot of platforms that will consist of basically once
signle source file. I think we need a directory for those. Maybe
platform/misc :) Or we could have them at the root of platforms/ in
fact... 

Paulus, what is your preference in that area ?

In the long run, it doesn't really matter in the sense that it's purely
the file location in the source tree, it has no effect on the content of
those files (+/- include path) or at runtime. You can still build kernel
with multiple images if the CPU cores are of the same category etc...
Thus, in this regard, it's almost cosmetic.
 
Cheers,
Ben.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 16:00       ` Sascha Hauer
  2006-11-02 20:49         ` Stephen Winiecki
@ 2006-11-02 22:25         ` Benjamin Herrenschmidt
  2006-11-02 22:32           ` Grant Likely
  1 sibling, 1 reply; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2006-11-02 22:25 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: linuxppc-dev

On Thu, 2006-11-02 at 17:00 +0100, Sascha Hauer wrote:
> On Thu, Nov 02, 2006 at 10:32:53AM -0500, Stephen Winiecki wrote:
> > 
> >    I also have a question about 750xx platforms.  I currently am looking at
> >    adding platform code supporting IBM 750GX/CL eval boards.  Where would
> >    they go - as well as others like Buckeye/Chestnut if/when they move over
> >    to /powerpc?
> 
> I don't know - Lets wait for ben and others what they say about this
> approach.
> My intention with this patch is to try and motivate people to
> integrate their machines as a part of the multiplatform support, because
> it doesn't cost a thing.

And that's a great move :) Thanks for doing that work !

> The presence of the embedded6xx entry and the entries in the directory
> itself makes people think (me too) that the multiplatform thing is only
> for the big irons. I think it's better to unify the two ways of platform
> support where it's possible.

Yes. I've been wanting to get rid of it for some time.

As for new platforms, I tend to have no problem if they just create a
directory of their own (platforms/chesnut, etc...) though in some we
might want a grab bag for boards that really only need one file...

This could be a plaforms/misc, or platforms/simple, or just have them at
the root of platforms...

Ben. 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 20:49         ` Stephen Winiecki
@ 2006-11-02 22:30           ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2006-11-02 22:30 UTC (permalink / raw)
  To: Stephen Winiecki; +Cc: linuxppc-dev


> What exactly is the intent of PPC_MULTIPLATFORM - the current desc
> states "Generic desktop/server/laptop" - which doesn't exactly scream
> 'embedded' to me either.  I guess I saw embedded6xx as a 'catch-all'
> for everything else.

It's historical. It was the good old prep/chrp/pmac option, meaning that
more than one board support can be built in the same kernel. I've made
the policy decision with ARCH=powerpc that we should now make that
mandatory for new boards (of course provided the CPUs are of the same
family) since, as Sascha rightfully pointed out, it costs nothing and
keeps things cleaner.

Thus I'm all about getting rid of the option :)

> I might be missing something - but when you removed EMBEDDED6xx from
> powerpc/Kconfig in patch 8, and removed MPC7448HPC2 from
> embedded6xx/Kconfig in patch 6 - where did you move the MPC7448HPC2
> config section to?  Is your thought that it will depend on
> PPC_MULTIPLATFORM now as well?

Board support are just boolean options depending on their CPU family
choice. That's the goal at least. I'm sure we are due for some Kconfig
cleanup to make that more visible :) We should probably split the
Kconfig into separate files for the various CPU families containing the
platforms for these families.

> This may be slightly off topic - but one other thing I have noticed
> that the new boot wrapper script supports specific 'types' of zImage
> files associated w/ 'MUTIPLATFORMS' (PSERIES, CHRP, PREP etc.) and
> uImage - which is what I think the majority of 'embedded' platforms
> will use by defining CONFIG_DEFAULT_UIMAGE.

That is not totally clear since they have non-compatible board info.

>   For IBM boards with PIBS just 'normal' zImage ELF files get loaded -
> I'm not sure if there should be another type defined/supported for
> boards which don't fit necessarily into a PSERIES/CHRP/PREP definition
> and also don't use uboot - CONFIG_DEFAULT_ZIMAGE? 
> 

Ask Paulus about the naming but pSeries is just "normal" in the sense
that it's "booted from a real OF" support.

The problem is despite the ability to do those nice multiplatform kernel
images, we still have bootloader incompatibilities. Thus we want to move
those to the zImage wrapper which can produce, from an already built
vmlinux binary, any zImage that can be supported for a given firmware
interface.

In the long run, we hope that firmwares will finally get their gears
together and use either a real OF entry point or a direct flat
device-tree entry point, which means that a single zImage (the "normal
one as you call it) will be able to boot everything.

There's also a glitch with real OF zImages due to the fact that IBM
pSeries OF requires a Notes section forcing OF into real mode while
Apple OF is allergic to that (it will crash badly) so we need to keep a
separate zImage for PowerMac. However, the vmlinux are the same so if
you use something like yaboot, the same vmlinux cna be booted on all
those machines.

Ben.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 22:25         ` Benjamin Herrenschmidt
@ 2006-11-02 22:32           ` Grant Likely
  0 siblings, 0 replies; 20+ messages in thread
From: Grant Likely @ 2006-11-02 22:32 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev

On 11/2/06, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> As for new platforms, I tend to have no problem if they just create a
> directory of their own (platforms/chesnut, etc...) though in some we
> might want a grab bag for boards that really only need one file...
>
> This could be a plaforms/misc, or platforms/simple, or just have them at
> the root of platforms...

Root of platforms makes sense to me.

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 22:13         ` Benjamin Herrenschmidt
@ 2006-11-03  9:12           ` Sascha Hauer
  0 siblings, 0 replies; 20+ messages in thread
From: Sascha Hauer @ 2006-11-03  9:12 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Paul Mackerras

On Fri, Nov 03, 2006 at 09:13:08AM +1100, Benjamin Herrenschmidt wrote:
> 
> > Then perhaps Efika should also be under platforms/mpc52xx?
> 
> Classifying platforms by their processor might not be the best idea... I
> makes some sense when those platforms are basically reference designs
> for the said processor but I yet have to be convinced it's really a good
> thing in the long run :)
> 
> There will be a lot of platforms that will consist of basically once
> signle source file. I think we need a directory for those. Maybe
> platform/misc :) Or we could have them at the root of platforms/ in
> fact... 
> 

In the embedded world there are many vendors of custom boards, so
such a directory might become very big, even if there is only one
file per board. Also I like the idea that I see all affected boards at
first sight when I change something in lets say the mpc52xx interrupt
controller.
I don't know how this performs in the 'big computer world' where vendors
combine a cpu with different chipsets. In the SoC world where every SoC
has the very same interrupt controller and device layout this behaves
quite well. Things become very orthogonal with per SoC directories.
(I'm more familiar with arm, where directories are organized this way,
so you might want to look at arch/arch/mach-* to see what I mean)

Sascha

-- 
 Dipl.-Ing. Sascha Hauer | http://www.pengutronix.de
  Pengutronix - Linux Solutions for Science and Industry
    Handelsregister: Amtsgericht Hildesheim, HRA 2686
      Hannoversche Str. 2, 31134 Hildesheim, Germany
    Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Fw: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
@ 2006-11-03 15:30 Stephen Winiecki
  2006-11-03 20:46 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 20+ messages in thread
From: Stephen Winiecki @ 2006-11-03 15:30 UTC (permalink / raw)
  To: benh; +Cc: linuxppc-dev, paulus

[-- Attachment #1: Type: text/plain, Size: 4332 bytes --]








Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote on 11/02/2006
05:30:25 PM:

>
> > What exactly is the intent of PPC_MULTIPLATFORM - the current desc
> > states "Generic desktop/server/laptop" - which doesn't exactly scream
> > 'embedded' to me either.  I guess I saw embedded6xx as a 'catch-all'
> > for everything else.
>
> It's historical. It was the good old prep/chrp/pmac option, meaning that
> more than one board support can be built in the same kernel. I've made
> the policy decision with ARCH=powerpc that we should now make that
> mandatory for new boards (of course provided the CPUs are of the same
> family) since, as Sascha rightfully pointed out, it costs nothing and
> keeps things cleaner.
>
> Thus I'm all about getting rid of the option :)
>

OK - so in this sense PPC_MULTIPLATFORM would be used more to help
categorize (make ppc platforms depend on it in Kconfig) as opposed to
enabling different code/function? (thus some of Sascha's patches getting
rid of CONFIG_PPC_MMULTIPLATFORM ifdefs)

> > This may be slightly off topic - but one other thing I have noticed
> > that the new boot wrapper script supports specific 'types' of zImage
> > files associated w/ 'MUTIPLATFORMS' (PSERIES, CHRP, PREP etc.) and
> > uImage - which is what I think the majority of 'embedded' platforms
> > will use by defining CONFIG_DEFAULT_UIMAGE.
>
> That is not totally clear since they have non-compatible board info.

I should have more properly said "the majority of the existing 'embedded'
platforms (not PSERIES, CHRP, PREP etc.) currently implmented in /power
seem to define CONFIG_DEFAULT_UIMAGE"

> >   For IBM boards with PIBS just 'normal' zImage ELF files get loaded -
> > I'm not sure if there should be another type defined/supported for
> > boards which don't fit necessarily into a PSERIES/CHRP/PREP definition
> > and also don't use uboot - CONFIG_DEFAULT_ZIMAGE?
> >
>
> Ask Paulus about the naming but pSeries is just "normal" in the sense
> that it's "booted from a real OF" support.
>
> The problem is despite the ability to do those nice multiplatform kernel
> images, we still have bootloader incompatibilities. Thus we want to move
> those to the zImage wrapper which can produce, from an already built
> vmlinux binary, any zImage that can be supported for a given firmware
> interface.
>
> In the long run, we hope that firmwares will finally get their gears
> together and use either a real OF entry point or a direct flat
> device-tree entry point, which means that a single zImage (the "normal
> one as you call it) will be able to boot everything.
>
> There's also a glitch with real OF zImages due to the fact that IBM
> pSeries OF requires a Notes section forcing OF into real mode while
> Apple OF is allergic to that (it will crash badly) so we need to keep a
> separate zImage for PowerMac. However, the vmlinux are the same so if
> you use something like yaboot, the same vmlinux cna be booted on all
> those machines.

Makes sense.  Specific to the current wrapper though - the boot Makefile
currently keys off the following for the different zImage 'types'

image-$(CONFIG_PPC_PSERIES)             += zImage.pseries
image-$(CONFIG_PPC_MAPLE)               += zImage.pseries
image-$(CONFIG_PPC_IBM_CELL_BLADE)      += zImage.pseries
image-$(CONFIG_PPC_CHRP)                += zImage.chrp
image-$(CONFIG_PPC_PMAC)                += zImage.pmac
image-$(CONFIG_DEFAULT_UIMAGE)          += uImage

My original point really was that if I have a ppc 'embedded' board which I
don't want to classify/define as PSERIES/MAPLE/CELL_BLADE/CHRP/PMAC, and I
don't want to generate a uImage, I think there needs to be another
definition, something like CONFIG_DEFAULT_ZIMAGE (similar to how
CONFIG_DEFAULT_UIMAGE is used in some of the existing /power platform defs
to create a uImage) which would be used to produce a 'normal' zImage type
(zImage.pseries?).  Basically - a definition analogous to the exisiting
CONFIG_DEFAULT_UIMAGE, but for zImage.  It would be used in a similar way -
where any platform could select in its configuration to result in a
'normal' zImage being created (indeed, could PPC_PSERIES/MAPLE/BLADE just
select this more generic definition and the Makefile use it instead?)

[-- Attachment #2: Type: text/html, Size: 5196 bytes --]

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: Fw: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-03 15:30 Fw: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry Stephen Winiecki
@ 2006-11-03 20:46 ` Benjamin Herrenschmidt
  2006-11-03 20:53   ` Olof Johansson
  0 siblings, 1 reply; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2006-11-03 20:46 UTC (permalink / raw)
  To: Stephen Winiecki; +Cc: linuxppc-dev, paulus


> OK - so in this sense PPC_MULTIPLATFORM would be used more to help
> categorize (make ppc platforms depend on it in Kconfig) as opposed to
> enabling different code/function? (thus some of Sascha's patches
> getting rid of CONFIG_PPC_MMULTIPLATFORM ifdefs)

I'd rather get rid of it completely.

> I should have more properly said "the majority of the existing
> 'embedded' platforms (not PSERIES, CHRP, PREP etc.) currently
> implmented in /power seem to define CONFIG_DEFAULT_UIMAGE"

Yes. Though I hope we'll see some alternatives to uboot soon

/me looks towards ojn and segher....

> Makes sense.  Specific to the current wrapper though - the boot
> Makefile currently keys off the following for the different zImage
> 'types'
> 
> image-$(CONFIG_PPC_PSERIES)             += zImage.pseries
> image-$(CONFIG_PPC_MAPLE)               += zImage.pseries
> image-$(CONFIG_PPC_IBM_CELL_BLADE)      += zImage.pseries
> image-$(CONFIG_PPC_CHRP)                += zImage.chrp
> image-$(CONFIG_PPC_PMAC)                += zImage.pmac
> image-$(CONFIG_DEFAULT_UIMAGE)          += uImage
> 
> My original point really was that if I have a ppc 'embedded' board
> which I don't want to classify/define as
> PSERIES/MAPLE/CELL_BLADE/CHRP/PMAC, and I don't want to generate a
> uImage, I think there needs to be another definition, something like
> CONFIG_DEFAULT_ZIMAGE (similar to how CONFIG_DEFAULT_UIMAGE is used in
> some of the existing /power platform defs to create a uImage) which
> would be used to produce a 'normal' zImage type (zImage.pseries?).

Yeah, that's what the zImage.pseries is :) Bad name I agree.

>   Basically - a definition analogous to the exisiting
> CONFIG_DEFAULT_UIMAGE, but for zImage.  It would be used in a similar
> way - where any platform could select in its configuration to result
> in a 'normal' zImage being created (indeed, could
> PPC_PSERIES/MAPLE/BLADE just select this more generic definition and
> the Makefile use it instead?)

Ben.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-03 20:46 ` Benjamin Herrenschmidt
@ 2006-11-03 20:53   ` Olof Johansson
  2006-11-03 21:32     ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 20+ messages in thread
From: Olof Johansson @ 2006-11-03 20:53 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, paulus

On Sat, 04 Nov 2006 07:46:15 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> Yes. Though I hope we'll see some alternatives to uboot soon
> 
> /me looks towards ojn and segher....

There's already PIBS, isn't there?


-Olof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-03 20:53   ` Olof Johansson
@ 2006-11-03 21:32     ` Benjamin Herrenschmidt
  2006-11-03 23:49       ` Olof Johansson
  0 siblings, 1 reply; 20+ messages in thread
From: Benjamin Herrenschmidt @ 2006-11-03 21:32 UTC (permalink / raw)
  To: Olof Johansson; +Cc: linuxppc-dev, paulus

On Fri, 2006-11-03 at 14:53 -0600, Olof Johansson wrote:
> On Sat, 04 Nov 2006 07:46:15 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > Yes. Though I hope we'll see some alternatives to uboot soon
> > 
> > /me looks towards ojn and segher....
> 
> There's already PIBS, isn't there?


But that's not a public/opensource thing people use regulary is it ?

Ben.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-03 21:32     ` Benjamin Herrenschmidt
@ 2006-11-03 23:49       ` Olof Johansson
  2006-11-04  1:41         ` Josh Boyer
  2006-11-04  2:07         ` Wolfgang Denk
  0 siblings, 2 replies; 20+ messages in thread
From: Olof Johansson @ 2006-11-03 23:49 UTC (permalink / raw)
  To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, paulus

On Sat, 04 Nov 2006 08:32:14 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> But that's not a public/opensource thing people use regulary is it ?

Might not be. I don't know what AMCC use for their eval boards, if it's
u-boot or PIBS or something else.


-Olof

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-03 23:49       ` Olof Johansson
@ 2006-11-04  1:41         ` Josh Boyer
  2006-11-04  2:07         ` Wolfgang Denk
  1 sibling, 0 replies; 20+ messages in thread
From: Josh Boyer @ 2006-11-04  1:41 UTC (permalink / raw)
  To: Olof Johansson; +Cc: paulus, linuxppc-dev

On Fri, 2006-11-03 at 17:49 -0600, Olof Johansson wrote:
> On Sat, 04 Nov 2006 08:32:14 +1100 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> 
> > But that's not a public/opensource thing people use regulary is it ?
> 
> Might not be. I don't know what AMCC use for their eval boards, if it's
> u-boot or PIBS or something else.

AMCC uses u-boot on their new boards.  Some of their older ones used
PIBS.

PIBS does have an open source type license.  You can download it as part
of the PPC 970FX eval kit.  Or other eval kits for various boards.

josh

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-03 23:49       ` Olof Johansson
  2006-11-04  1:41         ` Josh Boyer
@ 2006-11-04  2:07         ` Wolfgang Denk
  1 sibling, 0 replies; 20+ messages in thread
From: Wolfgang Denk @ 2006-11-04  2:07 UTC (permalink / raw)
  To: Olof Johansson; +Cc: paulus, linuxppc-dev

In message <20061103174948.34a5afe4@localhost.localdomain> you wrote:
> 
> Might not be. I don't know what AMCC use for their eval boards, if it's
> u-boot or PIBS or something else.

There is a working U-Boot configuration  for  all  AMCC  eval  boards
(including  downloadable  binary images). So if you want, you can use
U-Boot on all these boards.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It is impractical for  the  standard  to  attempt  to  constrain  the
behavior  of code that does not obey the constraints of the standard.
                                                          - Doug Gwyn

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry
  2006-11-02 12:56 ` [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry s.hauer
  2006-11-02 14:58   ` Grant Likely
@ 2006-11-21 15:13   ` Grant Likely
  1 sibling, 0 replies; 20+ messages in thread
From: Grant Likely @ 2006-11-21 15:13 UTC (permalink / raw)
  To: s.hauer@pengutronix.de; +Cc: linuxppc-dev

On 11/2/06, s.hauer@pengutronix.de <s.hauer@pengutronix.de> wrote:
> remove EMBEDDED6xx Kconfig entry
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

FWIW, I'm going to say ACK on this one.  Since this discussion, I've
moved my lite5200 support out of platforms/embedded6xx and changed it
to use CONFIG_PPC_MULTIPLATFORM

Cheers,
g.


>
> Index: linux-2.6/arch/powerpc/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/Kconfig
> +++ linux-2.6/arch/powerpc/Kconfig
> @@ -338,10 +338,6 @@ config PPC_MULTIPLATFORM
>           RS/6000 machine, an Apple machine, or a PReP, CHRP,
>           Maple or Cell-based machine.
>
> -config EMBEDDED6xx
> -       bool "Embedded 6xx/7xx/7xxx-based board"
> -       depends on PPC32 && (BROKEN||BROKEN_ON_SMP)
> -
>  config APUS
>         bool "Amiga-APUS"
>         depends on PPC32 && BROKEN
>
> --
>  Dipl.-Ing. Sascha Hauer | http://www.pengutronix.de
>   Pengutronix - Linux Solutions for Science and Industry
>     Handelsregister: Amtsgericht Hildesheim, HRA 2686
>       Hannoversche Str. 2, 31134 Hildesheim, Germany
>     Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>


-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely@secretlab.ca
(403) 399-0195

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2006-11-21 15:13 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-03 15:30 Fw: [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry Stephen Winiecki
2006-11-03 20:46 ` Benjamin Herrenschmidt
2006-11-03 20:53   ` Olof Johansson
2006-11-03 21:32     ` Benjamin Herrenschmidt
2006-11-03 23:49       ` Olof Johansson
2006-11-04  1:41         ` Josh Boyer
2006-11-04  2:07         ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2006-11-02 12:55 [patch 00/16] powerpc cleanup patches s.hauer
2006-11-02 12:56 ` [patch 08/16] powerpc: remove EMBEDDED6xx Kconfig entry s.hauer
2006-11-02 14:58   ` Grant Likely
2006-11-02 15:25     ` Sascha Hauer
2006-11-02 15:55       ` Grant Likely
2006-11-02 22:13         ` Benjamin Herrenschmidt
2006-11-03  9:12           ` Sascha Hauer
2006-11-02 15:32     ` Stephen Winiecki
2006-11-02 16:00       ` Sascha Hauer
2006-11-02 20:49         ` Stephen Winiecki
2006-11-02 22:30           ` Benjamin Herrenschmidt
2006-11-02 22:25         ` Benjamin Herrenschmidt
2006-11-02 22:32           ` Grant Likely
2006-11-21 15:13   ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).