From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sylvain Munaut <tnt@246tNt.com>
Cc: linuxppc-dev@ozlabs.org, linuxppc-embedded@ozlabs.org, sl@bplan-gmbh.de
Subject: Re: [PATCH/RFC] powerpc: Add of_platform support for OHCI/Bigendian HC
Date: Sun, 05 Nov 2006 09:15:16 +1100 [thread overview]
Message-ID: <1162678516.28571.60.camel@localhost.localdomain> (raw)
In-Reply-To: <454D0E58.4010100@246tNt.com>
On Sat, 2006-11-04 at 23:04 +0100, Sylvain Munaut wrote:
> Isn't it possible to specify "options" in the device tree rather than
> different names ?
> (just a though ...)
> It's just duplicating all that code doesn't look nice.
Well, he certainly doesn't need to different match lists.
He can just have both LE and BE in a single list and have probe()
routine go look at the property instead.
Ben.
> > +config USB_OHCI_HCD_PPC_OF
> > + bool "OHCI support for PPC USB controller for OpenFirmware platform"
> > + depends on USB_OHCI_HCD && PPC_OF
> > + default y
> > + select USB_OHCI_BIG_ENDIAN
> > + select USB_OHCI_LITTLE_ENDIAN
> > + ---help---
> > + Enables support for the USB controller PowerPC OpenFirmware platform
> > +
> >
> I know what benh said but do we really want to select both all the
> times. That adds
> quite an overhead to the accesses ...
What I said ws that I wanted them to be user-selectable options.
Ben.
next prev parent reply other threads:[~2006-11-04 22:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 20:31 [PATCH/RFC] powerpc: Add of_platform support for OHCI/Bigendian HC Nicolas DET
2006-11-01 22:23 ` Benjamin Herrenschmidt
2006-11-01 23:27 ` Benjamin Herrenschmidt
2006-11-02 20:49 ` Nicolas DET
2006-11-04 22:04 ` Sylvain Munaut
2006-11-04 22:15 ` Benjamin Herrenschmidt [this message]
2006-11-04 23:37 ` Benjamin Herrenschmidt
2006-11-01 23:49 ` Linas Vepstas
2006-11-02 0:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162678516.28571.60.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=sl@bplan-gmbh.de \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).