From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nicolas DET <nd@bplan-gmbh.de>
Cc: linuxppc-dev@ozlabs.org, sl@bplan-gmbh.de, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH/RFC] powerpc: Add of_platform support for OHCI/Bigendian HC
Date: Sun, 05 Nov 2006 10:37:45 +1100 [thread overview]
Message-ID: <1162683465.28571.85.camel@localhost.localdomain> (raw)
In-Reply-To: <454A59CC.6070902@bplan-gmbh.de>
On Thu, 2006-11-02 at 21:49 +0100, Nicolas DET wrote:
> fsoc-ppc. As I am not sure what it does exactly I
> left it like this. This module performs well here so far.
Well, it cause the kernel to keep other interrupts disabled on that CPU
while you are handling yours. Should not be necessary and might cause
undue latencies.
Regarding the rest of the patch, I don't understand why you are creating
duplicate match lists and probe/remove functions.
Just do a single of_platform_driver() that matches both and have it's
probe() function check the properties (device_is_compatible() would do
the trick, though a common thing in OF is to just have an empty property
"big-endian" in the node).
Ben.
next prev parent reply other threads:[~2006-11-04 23:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 20:31 [PATCH/RFC] powerpc: Add of_platform support for OHCI/Bigendian HC Nicolas DET
2006-11-01 22:23 ` Benjamin Herrenschmidt
2006-11-01 23:27 ` Benjamin Herrenschmidt
2006-11-02 20:49 ` Nicolas DET
2006-11-04 22:04 ` Sylvain Munaut
2006-11-04 22:15 ` Benjamin Herrenschmidt
2006-11-04 23:37 ` Benjamin Herrenschmidt [this message]
2006-11-01 23:49 ` Linas Vepstas
2006-11-02 0:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162683465.28571.85.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=nd@bplan-gmbh.de \
--cc=sl@bplan-gmbh.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).