From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH/RFC] powerpc: Add MPC5200 Interrupt Controller support. From: Benjamin Herrenschmidt To: Nicolas DET In-Reply-To: <20061105111753.3e41f6b7.nd@bplan-gmbh.de> References: <454902F9.20206@bplan-gmbh.de> <1162419138.25682.453.camel@localhost.localdomain> <454A1C37.5050208@bplan-gmbh.de> <454A5952.6090801@bplan-gmbh.de> <1162683341.28571.82.camel@localhost.localdomain> <20061105111753.3e41f6b7.nd@bplan-gmbh.de> Content-Type: text/plain Date: Sun, 05 Nov 2006 21:37:11 +1100 Message-Id: <1162723031.28571.228.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Sylvain Munaut , sl@bplan-gmbh.de, linuxppc-embedded@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > > You have changed the mapping of L1/L2 but not the device-tree > > representation to match them. Which means that you need the ugly hack > > above. That is not goot. Fix your device-tree instead and do the same > > split in the tree for L1/L2 than you do in the code. > > There is no option here. I don't agree. Your firmware can always be upgraded. There is no way you will impose a broken format on everybody else. Unfortunately, being the first implementation, that's just what you are doing... At worst, you'll have to do a fixup pass in prom_init.c > I have done it because other platform may add their how type/compatible/way to find the node. > For example, I did not find any bestcomm node in the recent lite5200 device-tree. > > http://ozlabs.org/pipermail/linuxppc-embedded/2006-November/024970.html They should get there ultimately. Ben.