From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/5] [RFC] Add support for lite5200b to arch/powerpc
Date: Tue, 07 Nov 2006 13:04:32 +1100 [thread overview]
Message-ID: <1162865073.28571.390.camel@localhost.localdomain> (raw)
In-Reply-To: <11628596753992-git-send-email-grant.likely@secretlab.ca>
> +static int __init lite5200_probe(void)
> +{
> + unsigned long node = of_get_flat_dt_root();
> + const char *model = of_get_flat_dt_prop(node, "model", NULL);
> +
> + if (!of_flat_dt_is_compatible(node, "mpc52xx"))
> + return 0;
> + pr_debug("%s board w/ mpc52xx found\n", model ? model : "unknown");
> +
> + return 1;
> +}
Are you creating a "generic" mpc52xx machine or a "lite5200b" machine ?
If you do the former, it will try to match on any board with that
compatible propery, thus any mpc52xx based board. That is probably not
what you want.
Put something like model "lite5200b" compatible "lite5200" "lite5200b"
in your / and check for that. Call you board lite5200, not mpc52xx.
Ben.
next prev parent reply other threads:[~2006-11-07 2:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 0:34 [RFC] Lite5200(b) arch/powerpc patchset Grant Likely
2006-11-07 0:34 ` [PATCH 1/5] Add Lite5200B device tree Grant Likely
2006-11-07 0:34 ` [PATCH 2/5] [RFC] Add support for lite5200b to arch/powerpc Grant Likely
2006-11-07 0:34 ` [PATCH 3/5] MPC52xx serial driver whitespace cleanup Grant Likely
2006-11-07 0:34 ` [PATCH 4/5] Move mpc52xx-psc uart driver to of_device from platform_device Grant Likely
2006-11-07 0:34 ` [PATCH 5/5] mpc52xx_init_irq() needs to panic() on failure Grant Likely
2006-11-07 2:04 ` Benjamin Herrenschmidt [this message]
2006-11-07 4:00 ` [PATCH 2/5] [RFC] Add support for lite5200b to arch/powerpc Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162865073.28571.390.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox