From: Vitaly Wool <vwool@ru.mvista.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] adding ROM chips to device tree: respin
Date: Wed, 08 Nov 2006 00:17:01 +0300 [thread overview]
Message-ID: <1162934221.2680.2.camel@barja> (raw)
In-Reply-To: <4550A5E6.50409@ru.mvista.com>
> > + - memory_space : Offset and length of the register set for the device.
>
> NAK. There's no need to define an extra property where "reg" should be used.
The register set is actually not there and depends on flash chip type.
So using regs here is misleading.
> > +
> > + /*
> > + * We care only about physmap devices now as there's no
> > + * description defined for other ROM types yet
> > + */
>
> Not true. The description only says that it's *most probably* compatible
> with "physmap", that's all. I don't see why we have to limit ourselves here.
Effectively we care about NOR chips and similar which are
memory-mapped.
Vitaly
next prev parent reply other threads:[~2006-11-07 21:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-07 11:19 [PATCH] adding ROM chips to device tree: respin Vitaly Wool
2006-11-07 15:27 ` Sergei Shtylyov
2006-11-07 21:17 ` Vitaly Wool [this message]
2006-11-07 21:25 ` Sergei Shtylyov
2006-11-07 21:44 ` Vitaly Wool
2006-11-07 21:52 ` Sergei Shtylyov
2006-11-07 22:18 ` Vitaly Wool
2006-11-07 22:40 ` Sergei Shtylyov
2006-11-08 14:27 ` Sergei Shtylyov
-- strict thread matches above, loose matches on Subject: below --
2006-11-09 18:41 Vitaly Wool
2006-11-14 15:47 Vitaly Wool
2006-11-14 15:59 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162934221.2680.2.camel@barja \
--to=vwool@ru.mvista.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).