From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id BD90367D20 for ; Wed, 8 Nov 2006 08:44:19 +1100 (EST) Subject: Re: [PATCH] adding ROM chips to device tree: respin From: Vitaly Wool To: Sergei Shtylyov In-Reply-To: <4550F9B8.40901@ru.mvista.com> References: <20061107141923.16b2d2f1.vwool@ru.mvista.com> <4550A5E6.50409@ru.mvista.com> <1162934221.2680.2.camel@barja> <4550F9B8.40901@ru.mvista.com> Content-Type: text/plain; charset=Windows-1251 Date: Wed, 08 Nov 2006 00:44:22 +0300 Message-Id: <1162935862.2680.7.camel@barja> Mime-Version: 1.0 Cc: linuxppc-embedded@ozlabs.org List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Â Ñð, 08/11/2006 â 00:25 +0300, Sergei Shtylyov ïèøåò: > Hello. > > Vitaly Wool wrote: > >>>+ - memory_space : Offset and length of the register set for the device. > >> > >> NAK. There's no need to define an extra property where "reg" should be used. > > > The register set is actually not there and depends on flash chip type. > > So using regs here is misleading. > > This is an I/O resource on the parent bus and using the property other > than "reg" will be misleading. That's the way this spec has it -- "reg" is > used even for the PHY chip numbering on MDIO bus... So what? Lemme remind you that the actual registers *doesn't start* at the specified "start" so using regs is really a bad idea IMHO. > >>>+ > >>>+ /* > >>>+ * We care only about physmap devices now as there's no > >>>+ * description defined for other ROM types yet > >>>+ */ > > >> Not true. The description only says that it's *most probably* compatible > >>with "physmap", that's all. I don't see why we have to limit ourselves here. > > > Effectively we care about NOR chips and similar which are > > memory-mapped. > > So what? How "physmap" follows from this? Okay, probably we can go you way naming of_device by what it's compatible with. So that "physmap" compatible would be called "physmap-flash", "nand"-compatible would be called "nand-flash" etc. Does that work for you? Vitaly