From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>, Steve Fox <drfickle@us.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure
Date: Fri, 10 Nov 2006 20:58:44 +1100 [thread overview]
Message-ID: <1163152724.4982.159.camel@localhost.localdomain> (raw)
In-Reply-To: <17748.19234.278295.476881@cargo.ozlabs.ibm.com>
On Fri, 2006-11-10 at 20:49 +1100, Paul Mackerras wrote:
> Benjamin Herrenschmidt writes:
>
> > > Seems that the patch below has introduced USB_OHCI_HCD_PPC_OF enabled by
> > > default. When it and CONFIG_USB_OHCI_HCD_PPC_SOC are enabled which
> > > occured by default on my config then we end up with two module_init()
> > > calls, which is illegal.
> > >
> > > powerpc-add-of_platform-support-for-ohci-bigendian-hc
> > >
> > > I am guessing that we are only meant to be able to have one of these
> > > defined at a time? I changed the default to n for this and I could at
> > > least compile the kernel, but I am sure thats not the right fix.
> >
> > Paul, which patch did you merge ? I rejected the initial one that was
> > doing 2 drivers/probe routines and Nicolas did a new one.. You may have
> > taken the wrong one.
>
> I didn't merge either of them.
Ah, must be Andrew then. Andrew, can you drop this (along with the other
Efika/MPC5200) patches from -mm ? They'll get in via the powerpc merge
and I'll make sure Paulus gets the right versions.
Cheers,
Ben.
prev parent reply other threads:[~2006-11-10 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061108015452.a2bb40d2.akpm@osdl.org>
2006-11-09 15:04 ` 2.6.19-rc5-mm1 -- ppc64 ohci-hdc.c compile failure Andy Whitcroft
2006-11-09 22:43 ` Benjamin Herrenschmidt
2006-11-10 9:49 ` Paul Mackerras
2006-11-10 9:58 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163152724.4982.159.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=drfickle@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).