From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linuxppc-dev@ozlabs.org, Olaf Hering <olaf@aepfle.de>,
Gioele Barabucci <dev@gioelebarabucci.com>
Subject: Re: [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle]
Date: Sat, 11 Nov 2006 12:31:32 +1100 [thread overview]
Message-ID: <1163208692.4982.199.camel@localhost.localdomain> (raw)
In-Reply-To: <45551185.8080704@s5r6.in-berlin.de>
On Sat, 2006-11-11 at 00:55 +0100, Stefan Richter wrote:
> Benjamin Herrenschmidt wrote:
> > On Sat, 2006-11-11 at 00:07 +0100, Stefan Richter wrote:
> >> Actually, shouldn't ohci1394_pci_remove enlcose the platform code into
> >>
> >> if (machine_is(powermac)) {
>
> > Yes.
>
> And how does this expression evaluate on PowerBook G3 "Pismo"?
This will be true on all powerpc based apple machines, so it will be
true there too.
Ben.
next prev parent reply other threads:[~2006-11-11 1:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-05 10:41 [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle] Stefan Richter
2006-11-05 10:54 ` Benjamin Herrenschmidt
2006-11-05 11:22 ` Stefan Richter
2006-11-05 11:37 ` Stefan Richter
2006-11-05 12:59 ` Benjamin Herrenschmidt
2006-11-10 22:43 ` [PATCH 1/2] ieee1394: ohci1394: add PPC_PMAC platform code to driver probe Stefan Richter
2006-11-10 22:44 ` [PATCH 2/2] ieee1394: ohci1394: reformat PPC_PMAC platform code Stefan Richter
2006-11-06 16:58 ` [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle] Olaf Hering
2006-11-06 22:19 ` Benjamin Herrenschmidt
2006-11-07 7:08 ` Olaf Hering
2006-11-07 7:17 ` Benjamin Herrenschmidt
2006-11-10 22:39 ` Stefan Richter
2006-11-10 23:07 ` Stefan Richter
2006-11-10 23:10 ` Benjamin Herrenschmidt
2006-11-10 23:22 ` [PATCH update 1/3] ieee1394: ohci1394: add PPC_PMAC platform code to driver probe Stefan Richter
2006-11-10 23:23 ` [PATCH update 2/3] ieee1394: ohci1394: reformat PPC_PMAC platform code Stefan Richter
2006-11-10 23:26 ` [PATCH update 3/3] ieee1394: ohci1394: call PMac code in shutdown only for proper machines Stefan Richter
2006-11-10 23:55 ` [Fwd: [Bug 7431] New: ohci1394 Oops after a rmmod/modprobe cycle] Stefan Richter
2006-11-11 1:31 ` Benjamin Herrenschmidt [this message]
2006-11-13 17:58 ` Olaf Hering
2006-11-13 19:08 ` Stefan Richter
2006-11-14 2:09 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163208692.4982.199.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=dev@gioelebarabucci.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olaf@aepfle.de \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).