From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brian King <brking@us.ibm.com>
Cc: James.Bottomley@SteelEye.com, linuxppc-dev@ozlabs.org,
torvalds@osdl.org, Paul Mackerras <paulus@samba.org>,
akpm@osdl.org
Subject: Re: ipr SATA support is causing problems
Date: Sun, 12 Nov 2006 11:50:41 +1100 [thread overview]
Message-ID: <1163292641.4982.249.camel@localhost.localdomain> (raw)
In-Reply-To: <4556631C.1070308@us.ibm.com>
On Sat, 2006-11-11 at 17:56 -0600, Brian King wrote:
> Paul Mackerras wrote:
> > How hard would it be to make the SATA bits conditionally compiled in,
> > depending on CONFIG_ATA?
>
> I took a look at doing this. It got a bit messy with a bunch of ifdefs,
> then I realized that doing this would break module dependencies. If
> ipr does not depend on CONFIG_ATA, then libata will not automatically
> get loaded (or built into initrd's) when ipr is needed.
>
> The best way I can see to accomplish your desired goal is to do something
> like the fusion driver did and separate out the sas bits from the scsi
> bits and essentially end up with multiple ipr modules. Unfortunately,
> this is not 2.6.19 material, but I could start working on it if you
> thought it sounded like a reasonable direction.
Yeah, something like
/--- SATA sub-modules (depends on CONFIG_ATA)
- core IPR module /
\
\--- SAS sub-module (depends on CONFIG_SCSI)
\
\--- SCSI sub-module (depends on CONFIG_SCSI)
Or do you need SAS and SATA to be one and only one ?
Cheers,
Ben.
next prev parent reply other threads:[~2006-11-12 0:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 11:37 ipr SATA support is causing problems Paul Mackerras
2006-11-10 11:48 ` Josh Boyer
2006-11-10 12:07 ` Paul Mackerras
2006-11-10 13:14 ` Josh Boyer
2006-11-10 15:07 ` Brian King
2006-11-10 15:23 ` Brian King
2006-11-10 23:06 ` Paul Mackerras
2006-11-11 23:56 ` Brian King
2006-11-12 0:50 ` Benjamin Herrenschmidt [this message]
2006-11-12 3:55 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163292641.4982.249.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=brking@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).