From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 5/5] [POWERPC] 8xx: Add mpc885ads support and common mpc8xx.
Date: Tue, 14 Nov 2006 13:47:34 +1100 [thread overview]
Message-ID: <1163472455.5940.75.camel@localhost.localdomain> (raw)
In-Reply-To: <20061114012831.17455.32542.stgit@localhost.localdomain>
Few comments..
> +/*
> + * Called very early, device-tree isn't unflattened
> + */
> +int __init mpc8xx_probe(void)
> +{
> + unsigned long root = of_get_flat_dt_root();
> +
> + if (of_flat_dt_is_compatible(root, "mpc8xx"))
> + return 1;
> +
> + return 0;
> +}
Why hooks on that ?
Normally, board support files test for their specific board. Thus they
have their own probe() function, generally static just before the ppc_md
definition. You probably want to remove the above,.
> +define_machine(mpc885_ads) {
> + .name = "MPC885 ADS",
> + .probe = mpc8xx_probe,
Do your own probe function that specifically checks for and MPC885 ADS
board.
prev parent reply other threads:[~2006-11-14 2:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061114012504.17455.13833.stgit@localhost.localdomain>
2006-11-14 1:28 ` [PATCH 1/5] [POWERPC] 8xx: platform-specific mmu updates Vitaly Bordug
2006-11-14 1:28 ` [PATCH 2/5] [POWERPC] 8xx: generic 8xx code arch/powerpc port Vitaly Bordug
2006-11-15 18:23 ` Christoph Hellwig
2006-11-15 23:36 ` Vitaly Bordug
2006-11-16 22:48 ` Benjamin Herrenschmidt
2006-11-17 6:49 ` Christoph Hellwig
2006-11-17 8:00 ` Christoph Hellwig
2006-11-18 1:24 ` Dan Malek
2006-11-20 10:24 ` Christoph Hellwig
2006-11-21 0:26 ` Dan Malek
2006-11-14 1:28 ` [PATCH 3/5] [POWERPC] 8xx: platform-related changes to the fsl_soc.c Vitaly Bordug
2006-11-14 2:21 ` Benjamin Herrenschmidt
2006-11-14 12:48 ` Vitaly Bordug
2006-11-14 1:28 ` [PATCH 4/5] [POWERPC] 8xx: powerpc port of core CPM, CPM PIC, etc Vitaly Bordug
2006-11-14 2:44 ` Benjamin Herrenschmidt
2006-11-14 1:28 ` [PATCH 5/5] [POWERPC] 8xx: Add mpc885ads support and common mpc8xx Vitaly Bordug
2006-11-14 2:47 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163472455.5940.75.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).