From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: idr@us.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org,
airlied@gmail.com
Subject: Re: [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X
Date: Tue, 14 Nov 2006 16:16:26 +1100 [thread overview]
Message-ID: <1163481386.5940.103.camel@localhost.localdomain> (raw)
In-Reply-To: <20061113.210750.66175955.davem@davemloft.net>
On Mon, 2006-11-13 at 21:07 -0800, David Miller wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Date: Tue, 14 Nov 2006 12:59:54 +1100
>
> > If I "fix" the kernel to do the right thing, that is pass BAR values in
> > devices and expect BAR values in mmap, then I will break existing X
> > setups on machines where PCI is not mapped 1:1 (that is mostly CHRP
> > machines).
> >
> > The problem I'm fixing in this patch is that while we were providing the
> > hacked up value in "devices", we were expecting the BAR value in mmap,
> > and there are apps expecting us to be consistent between the two, thus
> > the breakage.
>
> Ok, I don't see much alternatives for you then. I have no real
> objections to your patch.
Thanks. Fortunately, it's all going away soon :-)
Ben.
next prev parent reply other threads:[~2006-11-14 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 8:16 [PATCH/RFC] powerpc: Fix mmap of PCI resource with hack for X Benjamin Herrenschmidt
2006-11-14 0:31 ` David Miller
2006-11-14 1:59 ` Benjamin Herrenschmidt
2006-11-14 5:07 ` David Miller
2006-11-14 5:16 ` Benjamin Herrenschmidt [this message]
2006-11-14 2:15 ` Ian Romanick
2006-11-14 3:02 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163481386.5940.103.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=airlied@gmail.com \
--cc=anton@samba.org \
--cc=davem@davemloft.net \
--cc=idr@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).