Re: [PATCH 7/16] powerpc: add support for ps3 platform

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

On Wed, 2006-11-15 at 17:41 -0800, Geoff Levand wrote:
> Christoph Hellwig wrote:

> >> +#if !defined(PPC_MSG_MIGRATE_TASK)
> >> +static const int PPC_MSG_MIGRATE_TASK = 2;
> >> +#endif
> > 
> > This looks rather odd, what is it trying to do?
> 
> 
> For some reason the definition of PPC_MSG_MIGRATE_TASK is sometimes 2, and
> sometimes not defined, depending on other config options.  It makes the code
> much simpler if it is always defined as 2.  Maybe it makes more sense if I
> change it to this:
> 
> #if !defined(PPC_MSG_MIGRATE_TASK)
> #define PPC_MSG_MIGRATE_TASK 2
> #endif

include/asm-powerpc/smp.h says:

/* This is unused now */
#if 0
#define PPC_MSG_MIGRATE_TASK    2
#endif


So it will never be defined. Why do you need it, you don't seem to use
it anywhere?

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]