From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 7/16] powerpc: add support for ps3 platform
Date: Fri, 17 Nov 2006 11:39:44 +1100 [thread overview]
Message-ID: <1163723984.5940.411.camel@localhost.localdomain> (raw)
In-Reply-To: <20061115180440.GB18856@lst.de>
> > +
> > +enum page_size {
> > + page_size_4k = 12U,
> > + page_size_64k = 16U,
> > + page_size_16m = 24U,
> > +};
>
> Please use ALL_CAPS for such constants.
And call them PAGE_SHIFT_* while at it :-)
Ben.
next prev parent reply other threads:[~2006-11-17 0:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 20:02 [PATCH 7/16] powerpc: add support for ps3 platform Geoff Levand
2006-11-10 21:23 ` Olof Johansson
2006-11-14 0:11 ` Geoff Levand
2006-11-15 17:54 ` Christoph Hellwig
2006-11-21 2:50 ` Paul Mackerras
2006-11-21 10:11 ` Arnd Bergmann
2006-11-21 10:15 ` Geert Uytterhoeven
2006-11-21 11:59 ` Paul Mackerras
2006-11-21 13:22 ` Christoph Hellwig
2006-11-21 13:42 ` Arnd Bergmann
2006-11-21 13:45 ` Christoph Hellwig
2006-11-21 19:54 ` Geoff Levand
2006-11-21 19:54 ` Geoff Levand
2006-11-21 19:54 ` Geoff Levand
2006-11-14 14:25 ` Geoff Levand
2006-11-11 11:21 ` Christoph Hellwig
2006-11-11 11:24 ` Christoph Hellwig
2006-11-11 11:50 ` Arnd Bergmann
2006-11-13 3:29 ` Geoff Levand
2006-11-14 14:00 ` Geoff Levand
2006-11-15 18:04 ` Christoph Hellwig
2006-11-16 1:41 ` Geoff Levand
2006-11-16 2:13 ` Michael Ellerman
2006-11-17 1:31 ` Geoff Levand
2006-11-17 6:41 ` Christoph Hellwig
2006-11-17 22:23 ` Benjamin Herrenschmidt
2006-11-18 2:02 ` Geoff Levand
2006-11-21 21:12 ` Geoff Levand
2006-11-17 0:39 ` Benjamin Herrenschmidt [this message]
2006-11-17 1:33 ` Geoff Levand
2006-11-17 1:42 ` Michael Ellerman
2006-11-17 2:04 ` Geoff Levand
2006-11-17 2:19 ` Michael Ellerman
2006-11-17 2:44 ` Geoff Levand
2006-11-16 16:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163723984.5940.411.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=hch@lst.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).