From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 7/16] powerpc: add support for ps3 platform From: Michael Ellerman To: Geoff Levand In-Reply-To: <455D18B8.8090006@am.sony.com> References: <4554DACB.8060809@am.sony.com> <20061115180440.GB18856@lst.de> <1163723984.5940.411.camel@localhost.localdomain> <455D1161.2020605@am.sony.com> <1163727734.16815.24.camel@localhost.localdomain> <455D18B8.8090006@am.sony.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-KBITT1eyeIEBmipwAgv+" Date: Fri, 17 Nov 2006 13:19:22 +1100 Message-Id: <1163729962.16815.25.camel@localhost.localdomain> Mime-Version: 1.0 Cc: Paul Mackerras , linuxppc-dev@ozlabs.org Reply-To: michael@ellerman.id.au List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --=-KBITT1eyeIEBmipwAgv+ Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2006-11-16 at 18:04 -0800, Geoff Levand wrote: > Michael Ellerman wrote: > > On Thu, 2006-11-16 at 17:33 -0800, Geoff Levand wrote: > >> Benjamin Herrenschmidt wrote: > >> >> > + > >> >> > +enum page_size { > >> >> > + page_size_4k =3D 12U, > >> >> > + page_size_64k =3D 16U, > >> >> > + page_size_16m =3D 24U, > >> >> > +}; > >> >>=20 > >> >> Please use ALL_CAPS for such constants. > >> >=20 > >> > And call them PAGE_SHIFT_* while at it :-) > >>=20 > >> The HV docs call this page size, so that is what I used for > >> the symbol. I'll look at the usage again and reconsider. > >=20 > > No need to look at it, it's a shift not a size, the page size is not 12 > > bytes. Keeping it consistent with the HV docs is a concern, but so is > > making it consistent with every other part of the kernel - which calls > > this a shift, see page.h f.e. >=20 > Well, I meant reconsider in more of a broad sense, in like, maybe I can j= ust do > something to get rid of it... Yeah ok, that's always a nice solution. My last post probably could have used a smiley in hindsight :) cheers --=20 Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person --=-KBITT1eyeIEBmipwAgv+ Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQBFXRwqdSjSd0sB4dIRAvODAJ9paS9xQGZJr1vaON1pON9cVVw4JACeM8ui 0wm0U2PdkYhvBk9Bgn9R874= =6IuM -----END PGP SIGNATURE----- --=-KBITT1eyeIEBmipwAgv+--