Re: [PATCH] powerpc: Add of_platform support for ROM devices

[Hollis Blanchard <hollis@penguinppc.org>]

On Mon, 2006-11-20 at 16:32 +0300, Vitaly Wool wrote:
> +
> +    Required properties:
> +
> +     - device_type : has to be "rom"
> +     - compatible : Should specify what this ROM device is compatible with
> +       (i.e. "onenand"). Currently, this is most likely to be "direct-mapped"
> +       (which corresponds to the MTD physmap mapping driver).
> +     - regs : Offset and length of the register set (or memory mapping) for
> +       the device.
> +
> +    Recommended properties :
> +
> +     - bank-width : Width of the flash data bus in bytes. Required
> +       for the NOR flashes (compatible == "direct-mapped" and others) ONLY.

Maybe you should put this in the Required section then, with a note that
it's only Recommended for non-NOR flashes. I can easily imagine somebody
ignoring every Recommendation section and missing this requirement.

> +     - partitions : Several pairs of 32-bit values where the first value is
> +       partition's offset from the start of the device and the second one is
> +       partition size in bytes with LSB used to signify a read only
> +       partititon (so, the parition size should always be an even number).

^^^ "partition" misspelled, twice. :)

-Hollis