* [PATCH] powerpc: fix OF pci flags parsing
@ 2006-11-28 3:21 Olof Johansson
2006-11-28 8:46 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Olof Johansson @ 2006-11-28 3:21 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
For PCI devices with only io ports, of_bus_pci_get_flags() will fall
through and still mark the resource as IORESOURCE_MEM.
Signed-off-by: Olof Johansson <olof@lixom.net>
---
This should be fine to hold until 2.6.20, since noone (as far as I
know) has hit it in the wild.
diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
index 346fb7b..0dfbe1c 100644
--- a/arch/powerpc/kernel/prom_parse.c
+++ b/arch/powerpc/kernel/prom_parse.c
@@ -160,9 +160,11 @@ static unsigned int of_bus_pci_get_flags
switch((w >> 24) & 0x03) {
case 0x01:
flags |= IORESOURCE_IO;
+ break;
case 0x02: /* 32 bits */
case 0x03: /* 64 bits */
flags |= IORESOURCE_MEM;
+ break;
}
if (w & 0x40000000)
flags |= IORESOURCE_PREFETCH;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: fix OF pci flags parsing
2006-11-28 3:21 [PATCH] powerpc: fix OF pci flags parsing Olof Johansson
@ 2006-11-28 8:46 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2006-11-28 8:46 UTC (permalink / raw)
To: Olof Johansson; +Cc: linuxppc-dev, paulus
On Mon, 2006-11-27 at 21:21 -0600, Olof Johansson wrote:
> For PCI devices with only io ports, of_bus_pci_get_flags() will fall
> through and still mark the resource as IORESOURCE_MEM.
>
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
Oops :-)
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> This should be fine to hold until 2.6.20, since noone (as far as I
> know) has hit it in the wild.
>
>
> diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
> index 346fb7b..0dfbe1c 100644
> --- a/arch/powerpc/kernel/prom_parse.c
> +++ b/arch/powerpc/kernel/prom_parse.c
> @@ -160,9 +160,11 @@ static unsigned int of_bus_pci_get_flags
> switch((w >> 24) & 0x03) {
> case 0x01:
> flags |= IORESOURCE_IO;
> + break;
> case 0x02: /* 32 bits */
> case 0x03: /* 64 bits */
> flags |= IORESOURCE_MEM;
> + break;
> }
> if (w & 0x40000000)
> flags |= IORESOURCE_PREFETCH;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-28 8:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-28 3:21 [PATCH] powerpc: fix OF pci flags parsing Olof Johansson
2006-11-28 8:46 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).