From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: michael@ellerman.id.au
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
paulus@samba.org, Arnd Bergmann <arnd@arndb.de>,
ppc-dev <linuxppc-dev@ozlabs.org>
Subject: Re: [POWERPC] fix cell pmu initialisation
Date: Wed, 06 Dec 2006 09:31:15 +1100 [thread overview]
Message-ID: <1165357875.5469.22.camel@localhost.localdomain> (raw)
In-Reply-To: <1165357316.4785.0.camel@concordia.ozlabs.ibm.com>
On Wed, 2006-12-06 at 09:21 +1100, Michael Ellerman wrote:
> On Wed, 2006-12-06 at 07:07 +1100, Benjamin Herrenschmidt wrote:
> > > 1. export a method from cbe_regs.c to find out whether the pmd
> > > regs are available and test that in cbe_init_pm_irq().
> > > 2. take you patch as is, with a comment hinting to fix it up
> > > when needed.
> > > 3. change cbe_init_pm_irq to be called explicitly from cbe_regs_init(),
> > > which already scans the device tree correctly.
> >
> > cbe_regs_init() is called from setup_arch(), which is _very_ early.
> >
> > cbe_init_pm_irq() must be called much later as it requests irqs.
> >
> > Right now, we should stick to the machine_is() solution. We'll look into
> > doing something better eventually when the need occurs.
>
> 4. Add a FIRMWARE_FEATURE for it.
Not sure yet ... it's not really a firmware feature... Let's keep the
machine_is(cell) for now.
Ben.
prev parent reply other threads:[~2006-12-05 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 4:54 [POWERPC] fix cell pmu initialisation Stephen Rothwell
2006-12-05 13:34 ` Arnd Bergmann
2006-12-05 20:07 ` Benjamin Herrenschmidt
2006-12-05 22:21 ` Michael Ellerman
2006-12-05 22:31 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165357875.5469.22.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).