From: Michael Ellerman <michael@ellerman.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 12/15] powerpc: Do not use op_model_cell under LPAR
Date: Tue, 12 Dec 2006 15:55:56 +1100 [thread overview]
Message-ID: <1165899356.14839.20.camel@concordia.ozlabs.ibm.com> (raw)
In-Reply-To: <1165899226.11914.20.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]
On Tue, 2006-12-12 at 15:53 +1100, Benjamin Herrenschmidt wrote:
> On Tue, 2006-12-12 at 15:13 +1100, Michael Ellerman wrote:
> > On Tue, 2006-12-12 at 13:02 +0900, Ishizaki Kou wrote:
> > > op_model_cell supports native Cell processor. Under LPAR environment,
> > > it cannot work.
> > >
> > > Signed-off-by: Kou Ishizaki <kou.ishizaki.co.jp>
> > > ---
> > >
> > > Index: linux-powerpc-git/arch/powerpc/oprofile/common.c
> > > diff -u linux-powerpc-git/arch/powerpc/oprofile/common.c:1.1.1.1 linux-powerpc-git/arch/powerpc/oprofile/common.c:1.2
> > > --- linux-powerpc-git/arch/powerpc/oprofile/common.c:1.1.1.1 Wed Dec 6 08:25:43 2006
> > > +++ linux-powerpc-git/arch/powerpc/oprofile/common.c Wed Dec 6 08:43:15 2006
> > > @@ -149,6 +149,8 @@
> > > #ifdef CONFIG_PPC64
> > > #ifdef CONFIG_PPC_CELL_NATIVE
> > > case PPC_OPROFILE_CELL:
> > > + if (firmware_has_feature(FW_FEATURE_LPAR))
> > > + return -ENODEV;
> > > model = &op_model_cell;
> > > break;
> > > #endif
> >
> > Is FW_FEATURE_LPAR is the right switch to use here, I'm not sure.
>
> For now, it probably is as none of the LPAR env. for cell work with that
> op_model.
Sure, there's probably twenty different things we could use at the
moment, I'm just wondering out loud if LPAR is the best thing to reduce
the chance we have to change it in the future.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-12-12 4:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 4:02 [PATCH 12/15] powerpc: Do not use op_model_cell under LPAR Ishizaki Kou
2006-12-12 4:13 ` Michael Ellerman
2006-12-12 4:53 ` Benjamin Herrenschmidt
2006-12-12 4:55 ` Michael Ellerman [this message]
2006-12-12 11:49 ` Ishizaki Kou
2006-12-12 19:55 ` Arnd Bergmann
2006-12-12 22:51 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165899356.14839.20.camel@concordia.ozlabs.ibm.com \
--to=michael@ellerman.id.au \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).