From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id B99A467B92 for ; Wed, 13 Dec 2006 07:49:23 +1100 (EST) Subject: Re: [PATCH 8/15] Supporting PCI bus and base of I/O From: Benjamin Herrenschmidt To: Arnd Bergmann In-Reply-To: <200612122103.41597.arnd@arndb.de> References: <200612120338.kBC3c08S020556@toshiba.co.jp> <200612122103.41597.arnd@arndb.de> Content-Type: text/plain Date: Wed, 13 Dec 2006 07:49:14 +1100 Message-Id: <1165956554.11914.54.camel@localhost.localdomain> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2006-12-12 at 21:03 +0100, Arnd Bergmann wrote: > On Tuesday 12 December 2006 04:37, Ishizaki Kou wrote: > > This patch includes support for pci buses, base of Celleb specific > > devices, and etc. It works on of_platform bus. > > > > Signed-off-by: Kou Ishizaki > > The code looks good to me, I guess it could go in, except that > I really don't like the concept of faking a PCI bus device when > it's not actually there. I guess the EPCI part of this is > not controversial, so it would be good if you can split that > out into a separate patch that we can merge first. I personally don't have a big problem with the fake PCI stuff. The spider and USB drivers are already working out of the box pretty much with PCI and that's exactly what we do on IBM blades (though the illusion is maintained by the firmware in our case). I agree that in the long run, it's better to move that to of_platform, but I wouldn't nack the patches for that. Ben.